Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update-resource-preset clears boolean parameters by default #2761

Closed
serhiy-storchaka opened this issue Jun 29, 2022 · 0 comments · Fixed by #2774
Closed

update-resource-preset clears boolean parameters by default #2761

serhiy-storchaka opened this issue Jun 29, 2022 · 0 comments · Fixed by #2774
Assignees
@serhiy-storchaka
Labels
bug Something isn't working

Comments

@serhiy-storchaka
Copy link
Contributor

neuro admin update-resource-preset clears boolean parameters "Round Robin" "Preemptible Node" if corresponding CLI options --scheduler and --preemptible-node are not specified.

It is expected that the preset parameter is only changed if the corresponding option is specified. Similar issue was solved for non-boolean parameters: #2089.
@serhiy-storchaka serhiy-storchaka added the bug Something isn't working label Jun 29, 2022
@serhiy-storchaka serhiy-storchaka self-assigned this Jul 5, 2022
@serhiy-storchaka serhiy-storchaka linked a pull request Jul 5, 2022 that will close this issue
Fix neuro admin update-resource-preset #2774
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serhiy-storchaka serhiy-storchaka

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix neuro admin update-resource-preset neuro-inc/apolo-cli
1 participant
@serhiy-storchaka