Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of cluster level defaults #2520

Merged
merged 3 commits into from
Jan 14, 2022

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Jan 11, 2022

Closes #2220

@romasku romasku requested a review from asvetlov January 12, 2022 09:24
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #2520 (fe13b68) into master (46f6e79) will increase coverage by 0.42%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2520      +/-   ##
==========================================
+ Coverage   85.47%   85.90%   +0.42%     
==========================================
  Files          70       70              
  Lines       11794    11846      +52     
  Branches     2293     2304      +11     
==========================================
+ Hits        10081    10176      +95     
+ Misses       1332     1282      -50     
- Partials      381      388       +7     
Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/admin.py 76.84% <93.75%> (+1.30%) ⬆️
neuro-cli/src/neuro_cli/formatters/admin.py 99.37% <95.83%> (-0.63%) ⬇️
neuro-sdk/src/neuro_sdk/_core.py 92.41% <0.00%> (-2.07%) ⬇️
neuro-cli/src/neuro_cli/asyncio_utils.py 77.48% <0.00%> (-0.67%) ⬇️
neuro-cli/src/neuro_cli/main.py 61.53% <0.00%> (-0.65%) ⬇️
neuro-sdk/src/neuro_sdk/_jobs.py 92.29% <0.00%> (+0.49%) ⬆️
neuro-cli/src/neuro_cli/job.py 81.48% <0.00%> (+1.16%) ⬆️
neuro-cli/src/neuro_cli/formatters/jobs.py 81.48% <0.00%> (+2.07%) ⬆️
neuro-cli/src/neuro_cli/ael.py 62.85% <0.00%> (+7.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46f6e79...fe13b68. Read the comment docs.

@asvetlov asvetlov merged commit 6a635d4 into master Jan 14, 2022
@asvetlov asvetlov deleted the rs/support-cluster-level-default-quota branch January 14, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

neuro admin add-cluster-user should set user quota to default value if regular user is added
2 participants