Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of symlinks in "neuro ls" #2400

Merged
merged 4 commits into from
Nov 17, 2021
Merged

Add support of symlinks in "neuro ls" #2400

merged 4 commits into from
Nov 17, 2021

Conversation

serhiy-storchaka
Copy link
Contributor

No description provided.

@serhiy-storchaka serhiy-storchaka added the enhancement New feature or request label Oct 27, 2021
@serhiy-storchaka serhiy-storchaka marked this pull request as ready for review October 27, 2021 11:47
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #2400 (7a56051) into master (2d65a1c) will increase coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2400   +/-   ##
=======================================
  Coverage   71.61%   71.62%           
=======================================
  Files          67       67           
  Lines       11764    11781   +17     
  Branches     1789     1790    +1     
=======================================
+ Hits         8425     8438   +13     
- Misses       3068     3071    +3     
- Partials      271      272    +1     
Impacted Files Coverage Δ
neuro-sdk/src/neuro_sdk/storage.py 92.19% <86.66%> (-0.15%) ⬇️
neuro-cli/src/neuro_cli/formatters/storage.py 87.69% <100.00%> (+0.04%) ⬆️
neuro-cli/src/neuro_cli/file_logging.py 78.94% <0.00%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d65a1c...7a56051. Read the comment docs.

Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asvetlov asvetlov merged commit 3e5e2d8 into master Nov 17, 2021
@asvetlov asvetlov deleted the ss/ls-symlink branch November 17, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants