Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to make buckets public #2306

Merged
merged 4 commits into from
Sep 14, 2021
Merged

Allow to make buckets public #2306

merged 4 commits into from
Sep 14, 2021

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Sep 14, 2021

No description provided.

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #2306 (55a36d6) into master (7646f40) will decrease coverage by 0.03%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2306      +/-   ##
==========================================
- Coverage   83.10%   83.07%   -0.04%     
==========================================
  Files          69       69              
  Lines       11640    11660      +20     
  Branches     1779     1780       +1     
==========================================
+ Hits         9674     9687      +13     
- Misses       1609     1616       +7     
  Partials      357      357              
Flag Coverage Δ
cli 63.90% <69.23%> (-0.03%) ⬇️
e2e 63.61% <38.09%> (-0.05%) ⬇️
sdk 81.15% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/blob_storage.py 62.24% <60.00%> (-0.07%) ⬇️
neuro-cli/src/neuro_cli/formatters/buckets.py 96.49% <100.00%> (+0.12%) ⬆️
neuro-sdk/src/neuro_sdk/buckets.py 66.45% <100.00%> (+0.34%) ⬆️
neuro-cli/src/neuro_cli/file_logging.py 78.94% <0.00%> (-5.27%) ⬇️
neuro-cli/src/neuro_cli/asyncio_utils.py 79.37% <0.00%> (-0.63%) ⬇️
neuro-sdk/src/neuro_sdk/jobs.py 91.02% <0.00%> (-0.17%) ⬇️
neuro-sdk/src/neuro_sdk/core.py 93.10% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7646f40...55a36d6. Read the comment docs.

@romasku romasku requested a review from asvetlov September 14, 2021 13:22
@romasku romasku merged commit cd7cbe3 into master Sep 14, 2021
@romasku romasku deleted the rs/bucket-publicity branch September 14, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants