Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate 'neuro run IMAGE CMD', use 'neuro run IMAGE -- CMD' instead #2260

Merged
merged 3 commits into from
Aug 19, 2021

Conversation

asvetlov
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #2260 (b405604) into master (0af876d) will decrease coverage by 0.22%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2260      +/-   ##
==========================================
- Coverage   84.57%   84.34%   -0.23%     
==========================================
  Files          66       66              
  Lines       10700    10710      +10     
  Branches     1687     1689       +2     
==========================================
- Hits         9049     9033      -16     
- Misses       1313     1337      +24     
- Partials      338      340       +2     
Flag Coverage Δ
cli 64.18% <25.00%> (-0.12%) ⬇️
e2e 60.93% <83.33%> (-0.56%) ⬇️
sdk 88.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/job.py 79.46% <83.33%> (+0.78%) ⬆️
neuro-cli/src/neuro_cli/ael.py 51.07% <0.00%> (-4.06%) ⬇️
neuro-sdk/src/neuro_sdk/core.py 93.10% <0.00%> (-1.38%) ⬇️
neuro-cli/src/neuro_cli/formatters/jobs.py 78.21% <0.00%> (-0.86%) ⬇️
neuro-cli/src/neuro_cli/main.py 74.16% <0.00%> (-0.61%) ⬇️
neuro-cli/src/neuro_cli/formatters/storage.py 93.91% <0.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af876d...b405604. Read the comment docs.

@asvetlov asvetlov merged commit b335968 into master Aug 19, 2021
@asvetlov asvetlov deleted the deprecate-bare-run branch August 19, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant