Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement public URI helpers #2253

Merged
merged 4 commits into from
Aug 17, 2021
Merged

Implement public URI helpers #2253

merged 4 commits into from
Aug 17, 2021

Conversation

asvetlov
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #2253 (e5a2642) into master (c612e63) will decrease coverage by 0.06%.
The diff coverage is 48.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2253      +/-   ##
==========================================
- Coverage   74.57%   74.51%   -0.07%     
==========================================
  Files          66       66              
  Lines       10666    10695      +29     
  Branches     1680     1687       +7     
==========================================
+ Hits         7954     7969      +15     
- Misses       2447     2458      +11     
- Partials      265      268       +3     
Flag Coverage Δ
cli 64.28% <ø> (+0.03%) ⬆️
sdk 88.62% <48.38%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-sdk/src/neuro_sdk/url_utils.py 85.24% <46.66%> (-5.67%) ⬇️
neuro-sdk/src/neuro_sdk/parser.py 67.68% <50.00%> (-2.32%) ⬇️
neuro-cli/src/neuro_cli/ael.py 16.46% <0.00%> (ø)
neuro-sdk/src/neuro_sdk/jobs.py 80.60% <0.00%> (+0.06%) ⬆️
neuro-cli/src/neuro_cli/job.py 43.88% <0.00%> (+0.10%) ⬆️
neuro-cli/src/neuro_cli/file_logging.py 84.21% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c612e63...e5a2642. Read the comment docs.

@asvetlov asvetlov merged commit 4211711 into master Aug 17, 2021
@asvetlov asvetlov deleted the uri-helpers branch August 17, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant