Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possiblity to disable pypi version check via setting env var #2237

Merged
merged 3 commits into from
Aug 6, 2021

Conversation

YevheniiSemendiak
Copy link
Contributor

We need to suppress version checks in different tools, which might have a lag before the release with the latest versions (such as neuromation base environment docker image, neuro-web-shell, etc.)

As an alternative - we could also utilize the auto_envvar_prefix feature from click, but I'm not sure whether we need that thing at the moment.

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #2237 (c8498a5) into master (a7bf50f) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head c8498a5 differs from pull request most recent head a7496a0. Consider uploading reports for the commit a7496a0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2237      +/-   ##
==========================================
- Coverage   84.61%   84.52%   -0.09%     
==========================================
  Files          66       66              
  Lines       10613    10616       +3     
  Branches     1658     1659       +1     
==========================================
- Hits         8980     8973       -7     
- Misses       1321     1328       +7     
- Partials      312      315       +3     
Flag Coverage Δ
cli 64.00% <ø> (-0.02%) ⬇️
e2e 61.61% <ø> (-0.15%) ⬇️
sdk 89.01% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/main.py 74.16% <ø> (-0.61%) ⬇️
neuro-sdk/src/neuro_sdk/core.py 92.41% <0.00%> (-2.07%) ⬇️
neuro-cli/src/neuro_cli/ael.py 48.95% <0.00%> (-0.82%) ⬇️
neuro-cli/src/neuro_cli/job.py 78.98% <0.00%> (-0.39%) ⬇️
neuro-sdk/src/neuro_sdk/jobs.py 92.01% <0.00%> (+0.02%) ⬆️
neuro-cli/src/neuro_cli/formatters/jobs.py 80.10% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7bf50f...a7496a0. Read the comment docs.

Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use envvar="NEURO_CLI_DISABLE_PYPI_VERSION_CHECK" instead and show_envvar=True.

It makes the env var ustodiscoverable in generated docs

@YevheniiSemendiak
Copy link
Contributor Author

Please use envvar="NEURO_CLI_DISABLE_PYPI_VERSION_CHECK" instead and show_envvar=True.

It makes the env var ustodiscoverable in generated docs

Pitty I didn't find such config by myself, thanks for the hint!
Done in c8498a5
cc @asvetlov

Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please write CHANGELOG.D/2237.feature file and click 'merge' when ready.

@YevheniiSemendiak YevheniiSemendiak merged commit df07f81 into master Aug 6, 2021
@YevheniiSemendiak YevheniiSemendiak deleted the ys/disable-pypi-check-env branch August 6, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants