Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a neuro storage du command #2201

Merged
merged 3 commits into from
Jul 8, 2021
Merged

Add a neuro storage du command #2201

merged 3 commits into from
Jul 8, 2021

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Jul 6, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #2201 (7f14dae) into master (79a2990) will decrease coverage by 0.03%.
The diff coverage is 93.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2201      +/-   ##
==========================================
- Coverage   84.82%   84.78%   -0.04%     
==========================================
  Files          65       65              
  Lines       10470    10503      +33     
  Branches     1639     1640       +1     
==========================================
+ Hits         8881     8905      +24     
- Misses       1280     1289       +9     
  Partials      309      309              
Flag Coverage Δ
cli 63.92% <84.61%> (+0.04%) ⬆️
e2e 61.40% <40.62%> (-0.44%) ⬇️
sdk 89.24% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/storage.py 80.41% <60.00%> (-0.61%) ⬇️
neuro-cli/src/neuro_cli/formatters/storage.py 94.26% <100.00%> (+0.08%) ⬆️
neuro-sdk/src/neuro_sdk/storage.py 93.68% <100.00%> (+0.22%) ⬆️
neuro-cli/src/neuro_cli/ael.py 47.90% <0.00%> (-1.63%) ⬇️
neuro-sdk/src/neuro_sdk/jobs.py 92.67% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79a2990...7f14dae. Read the comment docs.

@romasku romasku requested a review from asvetlov July 6, 2021 13:44
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please rename the command to df; it works more similar to the standard df than du. E.g., you cannot calculate the size of particular folder; only the total NFS storage size.

@romasku romasku merged commit 7c3f587 into master Jul 8, 2021
@romasku romasku deleted the rs/disk-usage branch July 8, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants