Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service accounts #2147

Merged
merged 5 commits into from
Jun 1, 2021
Merged

Service accounts #2147

merged 5 commits into from
Jun 1, 2021

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Jun 1, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #2147 (e7de08c) into master (1da3942) will increase coverage by 0.07%.
The diff coverage is 79.00%.

❗ Current head e7de08c differs from pull request most recent head 85e80b0. Consider uploading reports for the commit 85e80b0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2147      +/-   ##
==========================================
+ Coverage   74.48%   74.56%   +0.07%     
==========================================
  Files          62       65       +3     
  Lines       10190    10370     +180     
  Branches     1623     1635      +12     
==========================================
+ Hits         7590     7732     +142     
- Misses       2349     2387      +38     
  Partials      251      251              
Flag Coverage Δ
cli 64.00% <69.10%> (+0.09%) ⬆️
sdk 89.19% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/click_types.py 60.00% <40.00%> (-2.33%) ⬇️
neuro-cli/src/neuro_cli/service_accounts.py 50.00% <50.00%> (ø)
...o-cli/src/neuro_cli/formatters/service_accounts.py 92.85% <92.85%> (ø)
neuro-cli/src/neuro_cli/main.py 63.58% <100.00%> (+0.22%) ⬆️
neuro-sdk/src/neuro_sdk/__init__.py 84.21% <100.00%> (+0.42%) ⬆️
neuro-sdk/src/neuro_sdk/client.py 97.82% <100.00%> (+0.12%) ⬆️
neuro-sdk/src/neuro_sdk/config.py 90.65% <100.00%> (+0.07%) ⬆️
neuro-sdk/src/neuro_sdk/service_accounts.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1da3942...85e80b0. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jun 1, 2021

This pull request introduces 4 alerts when merging e7de08c into 1da3942 - view on LGTM.com

new alerts:

  • 3 for Implicit string concatenation in a list
  • 1 for Module is imported with 'import' and 'import from'

@romasku romasku requested a review from asvetlov June 1, 2021 09:23
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for a tiny documentation note.

:param str role: Authorization role to use for this service account.

:param ~typing.Optional[str] name: Name of the service account. Should be unique among all user's
service accounts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe the meaning of None for name and default_cluster

@romasku romasku merged commit 05645ba into master Jun 1, 2021
@romasku romasku deleted the rs/service-accounts branch June 1, 2021 11:33
@lgtm-com
Copy link

lgtm-com bot commented Jun 1, 2021

This pull request introduces 4 alerts when merging 85e80b0 into c790c7a - view on LGTM.com

new alerts:

  • 3 for Implicit string concatenation in a list
  • 1 for Module is imported with 'import' and 'import from'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants