-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service accounts #2147
Service accounts #2147
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2147 +/- ##
==========================================
+ Coverage 74.48% 74.56% +0.07%
==========================================
Files 62 65 +3
Lines 10190 10370 +180
Branches 1623 1635 +12
==========================================
+ Hits 7590 7732 +142
- Misses 2349 2387 +38
Partials 251 251
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This pull request introduces 4 alerts when merging e7de08c into 1da3942 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for a tiny documentation note.
:param str role: Authorization role to use for this service account. | ||
|
||
:param ~typing.Optional[str] name: Name of the service account. Should be unique among all user's | ||
service accounts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please describe the meaning of None
for name
and default_cluster
This pull request introduces 4 alerts when merging 85e80b0 into c790c7a - view on LGTM.com new alerts:
|
No description provided.