Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spinners to "list entity" commands #2105

Merged
merged 2 commits into from
May 11, 2021
Merged

Add spinners to "list entity" commands #2105

merged 2 commits into from
May 11, 2021

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Apr 27, 2021

No description provided.

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #2105 (c83e66d) into master (74196ef) will decrease coverage by 11.42%.
The diff coverage is 16.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2105       +/-   ##
===========================================
- Coverage   86.08%   74.66%   -11.43%     
===========================================
  Files          63       63               
  Lines       10128    10168       +40     
  Branches     1601     1607        +6     
===========================================
- Hits         8719     7592     -1127     
- Misses       1109     2331     +1222     
+ Partials      300      245       -55     
Flag Coverage Δ
cli 64.16% <16.07%> (-0.30%) ⬇️
e2e ?
sdk 89.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/admin.py 58.17% <0.00%> (-3.75%) ⬇️
neuro-cli/src/neuro_cli/config.py 54.43% <0.00%> (-5.92%) ⬇️
neuro-cli/src/neuro_cli/disks.py 49.25% <0.00%> (-41.52%) ⬇️
neuro-cli/src/neuro_cli/image.py 42.62% <0.00%> (-37.38%) ⬇️
neuro-cli/src/neuro_cli/job.py 42.80% <0.00%> (-36.74%) ⬇️
neuro-cli/src/neuro_cli/secrets.py 59.52% <0.00%> (-25.48%) ⬇️
neuro-cli/src/neuro_cli/share.py 47.31% <0.00%> (-50.50%) ⬇️
neuro-cli/src/neuro_cli/root.py 62.80% <36.00%> (-26.82%) ⬇️
neuro-cli/src/neuro_cli/blob_storage.py 29.41% <0.00%> (-52.95%) ⬇️
neuro-cli/src/neuro_cli/storage.py 31.90% <0.00%> (-48.78%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74196ef...c83e66d. Read the comment docs.

@asvetlov asvetlov merged commit 14ee800 into master May 11, 2021
@asvetlov asvetlov deleted the rs/loading-spinners branch May 11, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants