Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show actual permission if grant had no effect #2092

Merged
merged 3 commits into from
Apr 15, 2021

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Apr 14, 2021

Closes #2025

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #2092 (f6f661d) into master (1308810) will decrease coverage by 12.14%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2092       +/-   ##
===========================================
- Coverage   86.81%   74.66%   -12.15%     
===========================================
  Files          63       63               
  Lines       10034    10082       +48     
  Branches     1583     1596       +13     
===========================================
- Hits         8711     7528     -1183     
- Misses       1013     2309     +1296     
+ Partials      310      245       -65     
Flag Coverage Δ
cli 64.01% <0.00%> (+0.07%) ⬆️
e2e ?
sdk 89.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/share.py 48.35% <0.00%> (-51.65%) ⬇️
neuro-sdk/src/neuro_sdk/users.py 60.00% <100.00%> (-27.10%) ⬇️
neuro-cli/src/neuro_cli/blob_storage.py 29.41% <0.00%> (-52.95%) ⬇️
neuro-cli/src/neuro_cli/storage.py 31.90% <0.00%> (-48.78%) ⬇️
neuro-cli/src/neuro_cli/ael.py 16.08% <0.00%> (-48.61%) ⬇️
neuro-cli/src/neuro_cli/disks.py 50.76% <0.00%> (-40.00%) ⬇️
neuro-cli/src/neuro_cli/job.py 43.21% <0.00%> (-37.48%) ⬇️
neuro-cli/src/neuro_cli/image.py 43.33% <0.00%> (-36.67%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1308810...f6f661d. Read the comment docs.

Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a changenote please

@romasku romasku merged commit 2c24ace into master Apr 15, 2021
@romasku romasku deleted the rs/show-actual-grant-result branch April 15, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display the actual privilegy after acl grant command
2 participants