Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle spurious disconnects by trying to attach #2085

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Apr 12, 2021

No description provided.

@romasku romasku force-pushed the rs/attach-retry-check branch from 05579d0 to 21c70b8 Compare April 12, 2021 14:37
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #2085 (21c70b8) into master (8db11c7) will decrease coverage by 12.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2085       +/-   ##
===========================================
- Coverage   86.79%   74.63%   -12.17%     
===========================================
  Files          63       63               
  Lines       10030    10037        +7     
  Branches     1581     1582        +1     
===========================================
- Hits         8706     7491     -1215     
- Misses       1015     2302     +1287     
+ Partials      309      244       -65     
Flag Coverage Δ
cli 63.88% <0.00%> (-0.08%) ⬇️
e2e ?
sdk 89.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/ael.py 16.00% <0.00%> (-48.60%) ⬇️
neuro-cli/src/neuro_cli/blob_storage.py 29.41% <0.00%> (-52.95%) ⬇️
neuro-cli/src/neuro_cli/share.py 50.00% <0.00%> (-50.00%) ⬇️
neuro-cli/src/neuro_cli/storage.py 31.90% <0.00%> (-48.78%) ⬇️
neuro-cli/src/neuro_cli/disks.py 50.76% <0.00%> (-40.00%) ⬇️
neuro-cli/src/neuro_cli/job.py 43.21% <0.00%> (-37.48%) ⬇️
neuro-cli/src/neuro_cli/image.py 43.33% <0.00%> (-36.67%) ⬇️
neuro-sdk/src/neuro_sdk/users.py 59.13% <0.00%> (-27.96%) ⬇️
neuro-cli/src/neuro_cli/root.py 66.66% <0.00%> (-22.96%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8db11c7...21c70b8. Read the comment docs.

@romasku romasku merged commit f7fec64 into master Apr 15, 2021
@romasku romasku deleted the rs/attach-retry-check branch April 15, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants