Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop old pass-config env and volume in generate command #2074

Merged
merged 2 commits into from
Apr 5, 2021

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Apr 2, 2021

Closes #2071

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #2074 (887ee82) into master (dd11fc7) will decrease coverage by 0.90%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2074      +/-   ##
==========================================
- Coverage   86.84%   85.93%   -0.91%     
==========================================
  Files          62       62              
  Lines        9983     9985       +2     
  Branches     1575     1576       +1     
==========================================
- Hits         8670     8581      -89     
- Misses       1007     1108     +101     
+ Partials      306      296      -10     
Flag Coverage Δ
cli 63.87% <75.00%> (+0.01%) ⬆️
e2e 65.70% <0.00%> (-1.00%) ⬇️
sdk 89.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/job.py 79.38% <75.00%> (-1.09%) ⬇️
neuro-cli/src/neuro_cli/ael.py 50.23% <0.00%> (-15.32%) ⬇️
neuro-cli/src/neuro_cli/formatters/jobs.py 79.60% <0.00%> (-2.13%) ⬇️
neuro-sdk/src/neuro_sdk/jobs.py 92.46% <0.00%> (-1.23%) ⬇️
neuro-cli/src/neuro_cli/root.py 89.61% <0.00%> (-1.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd11fc7...887ee82. Read the comment docs.

@romasku romasku merged commit 4bbd01b into master Apr 5, 2021
@romasku romasku deleted the rs/fix-gen-command-with-pass-config branch April 5, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate-run-command handles --pass-config in a wrong way
2 participants