Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do print about removed disk by default #2056

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Mar 22, 2021

Closes #2024

@romasku romasku changed the title Do print about removed in by default Do print about removed disk by default Mar 22, 2021
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #2056 (5a36314) into master (c421d8d) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 5a36314 differs from pull request most recent head 870e5cc. Consider uploading reports for the commit 870e5cc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2056      +/-   ##
==========================================
- Coverage   84.37%   84.35%   -0.03%     
==========================================
  Files          62       62              
  Lines        9892     9892              
  Branches     1564     1564              
==========================================
- Hits         8346     8344       -2     
  Misses       1238     1238              
- Partials      308      310       +2     
Flag Coverage Δ
cli 63.99% <0.00%> (ø)
e2e 61.44% <0.00%> (-0.41%) ⬇️
sdk 88.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/disks.py 90.76% <0.00%> (+1.53%) ⬆️
neuro-cli/src/neuro_cli/blob_storage.py 81.76% <0.00%> (-0.59%) ⬇️
neuro-cli/src/neuro_cli/storage.py 80.36% <0.00%> (-0.31%) ⬇️
neuro-cli/src/neuro_cli/ael.py 40.52% <0.00%> (-0.24%) ⬇️
neuro-cli/src/neuro_cli/job.py 77.97% <0.00%> (-0.20%) ⬇️
neuro-cli/src/neuro_cli/asyncio_utils.py 79.47% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c421d8d...870e5cc. Read the comment docs.

Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog, please

@romasku romasku merged commit 6a482bf into master Mar 24, 2021
@romasku romasku deleted the rs/always-print-about-disk-removal branch March 24, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

neuro disk rm should show actually deleted disks
2 participants