Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix job progress formatting #2055

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Fix job progress formatting #2055

merged 2 commits into from
Mar 24, 2021

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Mar 22, 2021

Closes #2036

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #2055 (a43a8c5) into master (3851a73) will decrease coverage by 1.61%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2055      +/-   ##
==========================================
- Coverage   85.95%   84.33%   -1.62%     
==========================================
  Files          62       62              
  Lines        9892     9897       +5     
  Branches     1564     1565       +1     
==========================================
- Hits         8503     8347     -156     
- Misses       1097     1240     +143     
- Partials      292      310      +18     
Flag Coverage Δ
cli 63.93% <14.28%> (-0.06%) ⬇️
e2e 61.75% <0.00%> (-4.04%) ⬇️
sdk 88.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/formatters/jobs.py 78.72% <14.28%> (-2.50%) ⬇️
neuro-cli/src/neuro_cli/image.py 43.33% <0.00%> (-36.67%) ⬇️
neuro-cli/src/neuro_cli/formatters/images.py 72.48% <0.00%> (-16.11%) ⬇️
neuro-cli/src/neuro_cli/ael.py 40.76% <0.00%> (-8.88%) ⬇️
neuro-sdk/src/neuro_sdk/images.py 86.63% <0.00%> (-7.49%) ⬇️
neuro-cli/src/neuro_cli/main.py 72.67% <0.00%> (-2.18%) ⬇️
neuro-cli/src/neuro_cli/job.py 78.16% <0.00%> (-1.76%) ⬇️
neuro-cli/src/neuro_cli/root.py 87.97% <0.00%> (-1.64%) ⬇️
neuro-sdk/src/neuro_sdk/client.py 98.87% <0.00%> (-1.13%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3851a73...a43a8c5. Read the comment docs.

@romasku romasku merged commit 80bc4c7 into master Mar 24, 2021
@romasku romasku deleted the rs/fix-job-progress-formatter branch March 24, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job status reports overlap
2 participants