Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always print job reason if available #2047

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Always print job reason if available #2047

merged 3 commits into from
Mar 24, 2021

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Mar 17, 2021

No description provided.

@romasku romasku force-pushed the rs/always-print-reason branch from 0ec8f89 to 19fc774 Compare March 17, 2021 17:39
@romasku romasku requested a review from asvetlov March 17, 2021 17:39
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #2047 (00780ad) into master (3851a73) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2047      +/-   ##
==========================================
+ Coverage   85.95%   85.97%   +0.01%     
==========================================
  Files          62       62              
  Lines        9892     9904      +12     
  Branches     1564     1563       -1     
==========================================
+ Hits         8503     8515      +12     
- Misses       1097     1098       +1     
+ Partials      292      291       -1     
Flag Coverage Δ
cli 63.94% <100.00%> (-0.05%) ⬇️
e2e 65.78% <0.00%> (-0.01%) ⬇️
sdk 88.96% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/formatters/jobs.py 80.32% <100.00%> (-0.90%) ⬇️
neuro-cli/src/neuro_cli/job.py 79.30% <0.00%> (-0.62%) ⬇️
neuro-sdk/src/neuro_sdk/parsing_utils.py 96.64% <0.00%> (+0.07%) ⬆️
neuro-cli/src/neuro_cli/ael.py 50.11% <0.00%> (+0.47%) ⬆️
neuro-sdk/src/neuro_sdk/config.py 90.50% <0.00%> (+0.58%) ⬆️
neuro-cli/src/neuro_cli/asyncio_utils.py 79.47% <0.00%> (+0.66%) ⬆️
neuro-sdk/src/neuro_sdk/storage.py 93.10% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3851a73...00780ad. Read the comment docs.

@romasku romasku force-pushed the rs/always-print-reason branch from 19fc774 to 50c7dc1 Compare March 18, 2021 11:47
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add changelog please

@romasku romasku merged commit dcc81d6 into master Mar 24, 2021
@romasku romasku deleted the rs/always-print-reason branch March 24, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants