Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deletion images without tag #2010

Merged
merged 4 commits into from
Feb 23, 2021
Merged

Allow deletion images without tag #2010

merged 4 commits into from
Feb 23, 2021

Conversation

asvetlov
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #2010 (b7f58b9) into master (6e86ad1) will decrease coverage by 1.31%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2010      +/-   ##
==========================================
- Coverage   86.12%   84.81%   -1.32%     
==========================================
  Files          60       60              
  Lines        9753     9758       +5     
  Branches     1542     1545       +3     
==========================================
- Hits         8400     8276     -124     
- Misses       1066     1184     +118     
- Partials      287      298      +11     
Flag Coverage Δ
cli 64.21% <35.29%> (-0.06%) ⬇️
e2e 62.10% <40.00%> (-3.44%) ⬇️
sdk 89.13% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/image.py 43.33% <27.58%> (-36.67%) ⬇️
neuro-cli/src/neuro_cli/click_types.py 70.83% <100.00%> (-3.67%) ⬇️
neuro-cli/src/neuro_cli/job.py 75.21% <100.00%> (-2.34%) ⬇️
neuro-sdk/src/neuro_sdk/__init__.py 91.89% <100.00%> (ø)
neuro-cli/src/neuro_cli/formatters/images.py 72.48% <0.00%> (-16.11%) ⬇️
neuro-sdk/src/neuro_sdk/images.py 86.63% <0.00%> (-7.49%) ⬇️
neuro-cli/src/neuro_cli/ael.py 46.52% <0.00%> (-3.84%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e86ad1...4949bb8. Read the comment docs.

@asvetlov asvetlov merged commit e7c0855 into master Feb 23, 2021
@asvetlov asvetlov deleted the delete-image branch February 23, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant