Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase read buffer #2004

Merged
merged 2 commits into from
Feb 19, 2021
Merged

Increase read buffer #2004

merged 2 commits into from
Feb 19, 2021

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Feb 19, 2021

No description provided.

@romasku romasku requested a review from asvetlov February 19, 2021 13:02
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #2004 (a376cdc) into master (91f40ba) will increase coverage by 1.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2004      +/-   ##
==========================================
+ Coverage   84.76%   86.00%   +1.23%     
==========================================
  Files          60       60              
  Lines        9715     9715              
  Branches     1533     1533              
==========================================
+ Hits         8235     8355     +120     
+ Misses       1185     1073     -112     
+ Partials      295      287       -8     
Flag Coverage Δ
cli 64.25% <ø> (-0.02%) ⬇️
e2e 65.40% <ø> (+3.31%) ⬆️
sdk 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-sdk/src/neuro_sdk/core.py 94.55% <ø> (ø)
neuro-sdk/src/neuro_sdk/jobs.py 93.29% <0.00%> (+1.08%) ⬆️
neuro-sdk/src/neuro_sdk/client.py 100.00% <0.00%> (+1.12%) ⬆️
neuro-cli/src/neuro_cli/main.py 76.08% <0.00%> (+1.24%) ⬆️
neuro-cli/src/neuro_cli/root.py 89.61% <0.00%> (+1.63%) ⬆️
neuro-cli/src/neuro_cli/job.py 75.99% <0.00%> (+2.20%) ⬆️
neuro-cli/src/neuro_cli/ael.py 48.68% <0.00%> (+3.11%) ⬆️
neuro-cli/src/neuro_cli/click_types.py 74.64% <0.00%> (+5.63%) ⬆️
neuro-sdk/src/neuro_sdk/images.py 94.11% <0.00%> (+7.48%) ⬆️
neuro-cli/src/neuro_cli/formatters/images.py 88.59% <0.00%> (+16.10%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91f40ba...30d03b0. Read the comment docs.

Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please add a change note before the merging

@romasku romasku merged commit a803666 into master Feb 19, 2021
@romasku romasku deleted the rs/increase-buffer-size branch February 19, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants