Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print job id on detach #1993

Merged
merged 2 commits into from
Feb 16, 2021
Merged

Print job id on detach #1993

merged 2 commits into from
Feb 16, 2021

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Feb 15, 2021

Closes #1930

@romasku romasku requested a review from asvetlov February 15, 2021 10:35
@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #1993 (cf06850) into master (55b603e) will increase coverage by 1.23%.
The diff coverage is 75.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1993      +/-   ##
==========================================
+ Coverage   84.91%   86.14%   +1.23%     
==========================================
  Files          60       60              
  Lines        9612     9658      +46     
  Branches     1520     1527       +7     
==========================================
+ Hits         8162     8320     +158     
+ Misses       1158     1055     -103     
+ Partials      292      283       -9     
Flag Coverage Δ
cli 64.61% <46.15%> (-0.13%) ⬇️
e2e 65.33% <75.71%> (+3.33%) ⬆️
sdk 89.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/formatters/jobs.py 81.04% <50.00%> (+0.03%) ⬆️
neuro-cli/src/neuro_cli/click_types.py 74.64% <56.00%> (+2.85%) ⬆️
neuro-cli/src/neuro_cli/ael.py 49.49% <100.00%> (+3.04%) ⬆️
neuro-cli/src/neuro_cli/disks.py 89.06% <100.00%> (+0.92%) ⬆️
neuro-cli/src/neuro_cli/formatters/disks.py 98.55% <100.00%> (+0.06%) ⬆️
neuro-cli/src/neuro_cli/job.py 75.77% <100.00%> (+2.27%) ⬆️
neuro-cli/src/neuro_cli/utils.py 88.65% <100.00%> (+0.20%) ⬆️
neuro-sdk/src/neuro_sdk/disks.py 97.26% <100.00%> (+0.03%) ⬆️
neuro-cli/src/neuro_cli/asyncio_utils.py 79.47% <0.00%> (+0.66%) ⬆️
neuro-sdk/src/neuro_sdk/jobs.py 93.11% <0.00%> (+1.08%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b603e...03e66e7. Read the comment docs.

Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JobStopProgress should be modified in a similar way probably.

DetailedJobStopProgress.tick() has msg = yes() + " Stopped" line along with DetailedExecStopProgress.tick()

@romasku
Copy link
Contributor Author

romasku commented Feb 15, 2021

Sorry, I can't find a place that I missed updating.
I update both for DetailedJobStopProgress and DetailedExecStopProgress. The first update is line 714 (the change is tiny because JobDescription is available in tick()) and all other changed are related to DetailedExecStopProgress.

@romasku romasku requested a review from asvetlov February 15, 2021 11:43
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad.
LGTM after adding the changelog

@romasku romasku merged commit be8cc6e into master Feb 16, 2021
@romasku romasku deleted the rs/job-id-on-detach branch February 16, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: print job id after detaching from the job or job logs
2 participants