-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print job id on detach #1993
Print job id on detach #1993
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1993 +/- ##
==========================================
+ Coverage 84.91% 86.14% +1.23%
==========================================
Files 60 60
Lines 9612 9658 +46
Branches 1520 1527 +7
==========================================
+ Hits 8162 8320 +158
+ Misses 1158 1055 -103
+ Partials 292 283 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JobStopProgress
should be modified in a similar way probably.
DetailedJobStopProgress.tick()
has msg = yes() + " Stopped"
line along with DetailedExecStopProgress.tick()
Sorry, I can't find a place that I missed updating. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my bad.
LGTM after adding the changelog
Closes #1930