Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named disks #1983

Merged
merged 9 commits into from
Feb 12, 2021
Merged

Named disks #1983

merged 9 commits into from
Feb 12, 2021

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Feb 10, 2021

No description provided.

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #1983 (f76044f) into master (55b603e) will increase coverage by 1.26%.
The diff coverage is 80.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1983      +/-   ##
==========================================
+ Coverage   84.91%   86.17%   +1.26%     
==========================================
  Files          60       60              
  Lines        9612     9657      +45     
  Branches     1520     1527       +7     
==========================================
+ Hits         8162     8322     +160     
+ Misses       1158     1053     -105     
+ Partials      292      282      -10     
Flag Coverage Δ
cli 64.62% <50.00%> (-0.12%) ⬇️
e2e 65.38% <80.70%> (+3.38%) ⬆️
sdk 89.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/click_types.py 74.64% <56.00%> (+2.85%) ⬆️
neuro-cli/src/neuro_cli/disks.py 89.06% <100.00%> (+0.92%) ⬆️
neuro-cli/src/neuro_cli/formatters/disks.py 98.55% <100.00%> (+0.06%) ⬆️
neuro-cli/src/neuro_cli/job.py 75.55% <100.00%> (+2.05%) ⬆️
neuro-cli/src/neuro_cli/utils.py 88.65% <100.00%> (+0.20%) ⬆️
neuro-sdk/src/neuro_sdk/disks.py 97.26% <100.00%> (+0.03%) ⬆️
neuro-sdk/src/neuro_sdk/jobs.py 93.11% <0.00%> (+1.08%) ⬆️
neuro-sdk/src/neuro_sdk/client.py 100.00% <0.00%> (+1.12%) ⬆️
neuro-cli/src/neuro_cli/main.py 76.01% <0.00%> (+2.49%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b603e...1b5862f. Read the comment docs.

@romasku romasku merged commit fadeadc into master Feb 12, 2021
@romasku romasku deleted the rs/named-disks branch February 12, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants