Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the rich library for logging. #1897

Closed
wants to merge 2 commits into from
Closed

Conversation

serhiy-storchaka
Copy link
Contributor

@serhiy-storchaka serhiy-storchaka commented Dec 9, 2020

Closes #1887.

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #1897 (575c013) into master (5d5e984) will increase coverage by 3.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1897      +/-   ##
==========================================
+ Coverage   86.01%   89.47%   +3.46%     
==========================================
  Files          60       25      -35     
  Lines        9382     4067    -5315     
  Branches     1466      631     -835     
==========================================
- Hits         8070     3639    -4431     
+ Misses       1034      318     -716     
+ Partials      278      110     -168     
Flag Coverage Δ
cli ?
e2e ?
sdk 89.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuro-sdk/neuro_sdk/users.py 59.13% <0.00%> (-27.96%) ⬇️
neuro-sdk/neuro_sdk/parser.py 68.96% <0.00%> (-20.69%) ⬇️
neuro-sdk/neuro_sdk/tracing.py 88.00% <0.00%> (-12.00%) ⬇️
neuro-sdk/neuro_sdk/jobs.py 83.30% <0.00%> (-9.76%) ⬇️
neuro-sdk/neuro_sdk/__init__.py 83.78% <0.00%> (-8.11%) ⬇️
neuro-sdk/neuro_sdk/images.py 86.63% <0.00%> (-7.49%) ⬇️
neuro-sdk/neuro_sdk/core.py 88.27% <0.00%> (-6.21%) ⬇️
neuro-sdk/neuro_sdk/blob_storage.py 90.27% <0.00%> (-2.76%) ⬇️
neuro-sdk/neuro_sdk/client.py 97.77% <0.00%> (-2.23%) ⬇️
neuro-sdk/neuro_sdk/config_factory.py 93.02% <0.00%> (-1.56%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5e984...2940fe0. Read the comment docs.

Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asvetlov
Copy link
Contributor

Please take a look at failed tests

@serhiy-storchaka
Copy link
Contributor Author

Humm, many tests in test_alias are failed. It is not good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug output of storage cp is full of error messages
2 participants