Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing the "Last-Modified" header in Blob Storage #1874

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

serhiy-storchaka
Copy link
Contributor

It was parsed in local timezone.

Also simplify parsing the "Date" header in Storage.

@serhiy-storchaka serhiy-storchaka added the bug Something isn't working label Nov 30, 2020
It was parsed in local timezone.

Also simplify parsing the "Date" header in Storage.
@serhiy-storchaka serhiy-storchaka force-pushed the ss/blob-storage-parse-datetime branch from f8d23b9 to 381624a Compare November 30, 2020 17:17
@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #1874 (c888b85) into master (5fa0b5b) will decrease coverage by 0.03%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1874      +/-   ##
==========================================
- Coverage   86.77%   86.73%   -0.04%     
==========================================
  Files          62       62              
  Lines        9444     9440       -4     
  Branches     1490     1486       -4     
==========================================
- Hits         8195     8188       -7     
- Misses        970      977       +7     
+ Partials      279      275       -4     
Flag Coverage Δ
e2e 65.04% <72.72%> (-0.03%) ⬇️
unit 76.45% <72.72%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuromation/api/blob_storage.py 93.65% <66.66%> (-0.02%) ⬇️
neuromation/api/storage.py 92.30% <80.00%> (+0.33%) ⬆️
neuromation/cli/formatters/jobs.py 79.92% <0.00%> (-0.96%) ⬇️
neuromation/cli/ael.py 49.49% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fa0b5b...381624a. Read the comment docs.

@serhiy-storchaka serhiy-storchaka merged commit 482713a into master Nov 30, 2020
@serhiy-storchaka serhiy-storchaka deleted the ss/blob-storage-parse-datetime branch November 30, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant