Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use partial read when retry to download blob #1865

Merged
merged 3 commits into from
Nov 25, 2020

Conversation

serhiy-storchaka
Copy link
Contributor

No description provided.

@serhiy-storchaka serhiy-storchaka added the enhancement New feature or request label Nov 24, 2020
@serhiy-storchaka serhiy-storchaka marked this pull request as ready for review November 24, 2020 10:20
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #1865 (dd87435) into master (3ff7b47) will increase coverage by 0.01%.
The diff coverage is 77.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1865      +/-   ##
==========================================
+ Coverage   86.41%   86.42%   +0.01%     
==========================================
  Files          62       62              
  Lines        9390     9412      +22     
  Branches     1470     1479       +9     
==========================================
+ Hits         8114     8134      +20     
+ Misses       1002     1001       -1     
- Partials      274      277       +3     
Flag Coverage Δ
e2e 65.02% <38.70%> (-0.07%) ⬇️
unit 76.21% <77.41%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuromation/api/blob_storage.py 93.66% <77.41%> (-1.29%) ⬇️
neuromation/cli/asyncio_utils.py 76.82% <0.00%> (-0.67%) ⬇️
neuromation/cli/ael.py 48.98% <0.00%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ff7b47...133f5f6. Read the comment docs.

@serhiy-storchaka serhiy-storchaka merged commit b68e108 into master Nov 25, 2020
@serhiy-storchaka serhiy-storchaka deleted the ss/retry-blob-download branch November 25, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant