Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resource_presets management commands #1863

Merged
merged 7 commits into from
Nov 26, 2020

Conversation

zubenkoivan
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #1863 (fab2c00) into master (6e219de) will increase coverage by 0.12%.
The diff coverage is 91.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1863      +/-   ##
==========================================
+ Coverage   86.58%   86.70%   +0.12%     
==========================================
  Files          62       62              
  Lines        9389     9450      +61     
  Branches     1470     1486      +16     
==========================================
+ Hits         8129     8194      +65     
+ Misses        986      976      -10     
- Partials      274      280       +6     
Flag Coverage Δ
e2e 65.03% <54.48%> (-0.25%) ⬇️
unit 76.46% <69.65%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuromation/api/config.py 91.71% <ø> (ø)
neuromation/cli/formatters/utils.py 96.55% <ø> (+38.48%) ⬆️
neuromation/cli/topics.py 66.66% <42.85%> (-2.23%) ⬇️
neuromation/api/blob_storage.py 93.66% <77.41%> (-1.29%) ⬇️
neuromation/api/storage.py 91.96% <88.88%> (-0.36%) ⬇️
neuromation/api/admin.py 99.31% <100.00%> (+0.07%) ⬆️
neuromation/api/server_cfg.py 93.65% <100.00%> (+0.10%) ⬆️
neuromation/cli/admin.py 59.59% <100.00%> (+8.08%) ⬆️
neuromation/cli/blob_storage.py 83.33% <100.00%> (+0.59%) ⬆️
neuromation/cli/formatters/config.py 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e219de...1e36b88. Read the comment docs.

@zubenkoivan zubenkoivan marked this pull request as ready for review November 24, 2020 07:07
@zubenkoivan zubenkoivan requested a review from asvetlov November 24, 2020 07:11
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except a minor thing

neuromation/cli/admin.py Outdated Show resolved Hide resolved
neuromation/cli/admin.py Outdated Show resolved Hide resolved
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixing click.style() with rich.print() can produce unexpected behavior.

LGTM after applying suggested changes.

neuromation/cli/admin.py Outdated Show resolved Hide resolved
neuromation/cli/admin.py Outdated Show resolved Hide resolved
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please feel free to merge when ready.

@zubenkoivan zubenkoivan merged commit 282077d into master Nov 26, 2020
@zubenkoivan zubenkoivan deleted the add_resource_presets_commands branch November 26, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants