-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add resource_presets management commands #1863
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1863 +/- ##
==========================================
+ Coverage 86.58% 86.70% +0.12%
==========================================
Files 62 62
Lines 9389 9450 +61
Branches 1470 1486 +16
==========================================
+ Hits 8129 8194 +65
+ Misses 986 976 -10
- Partials 274 280 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except a minor thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixing click.style()
with rich.print()
can produce unexpected behavior.
LGTM after applying suggested changes.
Co-authored-by: Andrew Svetlov <[email protected]>
Co-authored-by: Andrew Svetlov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please feel free to merge when ready.
No description provided.