Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display restarts in cli when there was restarts #1859

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Nov 20, 2020

No description provided.

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #1859 (1c504a2) into master (4cf2f9e) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1859      +/-   ##
==========================================
- Coverage   86.68%   86.60%   -0.09%     
==========================================
  Files          62       62              
  Lines        9389     9391       +2     
  Branches     1470     1471       +1     
==========================================
- Hits         8139     8133       -6     
- Misses        978      985       +7     
- Partials      272      273       +1     
Flag Coverage Δ
e2e 65.26% <91.66%> (-0.14%) ⬇️
unit 76.23% <16.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neuromation/cli/blob_storage.py 83.33% <100.00%> (+0.59%) ⬆️
neuromation/cli/formatters/jobs.py 79.80% <100.00%> (-0.93%) ⬇️
neuromation/cli/formatters/storage.py 94.17% <100.00%> (+0.01%) ⬆️
neuromation/cli/storage.py 80.73% <100.00%> (+0.30%) ⬆️
neuromation/cli/ael.py 48.98% <0.00%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf2f9e...92a1b47. Read the comment docs.

Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.
Did you have a feature request or just make the implementation similar to other properties displaying?

P.S.
Add CHANGELOG please

@romasku
Copy link
Contributor Author

romasku commented Nov 24, 2020

Did you have a feature request or just make the implementation similar to other properties displaying?

There was a discussion in slack about preemptible jobs (and how to get a number of restarts for them). Then I updated the server to count SUSPENDED as a restart in neuro-inc/platform-api#1399, and this is PR to the client that makes this functionality visible in CLI.

@asvetlov
Copy link
Contributor

ok, thanks

@asvetlov asvetlov merged commit dc5fe71 into master Dec 2, 2020
@asvetlov asvetlov deleted the rs/fix-condition-to-display-restart branch December 2, 2020 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants