Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

END-486: new cmds for org/user balance #3137

Merged
merged 5 commits into from
Dec 4, 2024
Merged

END-486: new cmds for org/user balance #3137

merged 5 commits into from
Dec 4, 2024

Conversation

parikls
Copy link
Contributor

@parikls parikls commented Nov 29, 2024

No description provided.

@linear Linear
Copy link

linear bot commented Nov 29, 2024

ENG-486 move credits to an org-user instead of a cluster-user

@parikls parikls force-pushed the ENG-486-new-admin-cmds-for-org-user-credits branch from 14895c3 to a3dab39 Compare December 4, 2024 13:07
asvetlov
asvetlov approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Please add a file ./CHANGELOG.D/3137.feature with new feature description. A sentence or two in a free form should be enough, Markdown formatting is supported if needed.

@parikls parikls force-pushed the ENG-486-new-admin-cmds-for-org-user-credits branch from b6eb6e3 to 33c7660 Compare December 4, 2024 14:02
asvetlov
asvetlov reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few minor notes.

Also, it would be nice of changelog record will reflect the formatters change also.

CHANGELOG.D/3137.feature Outdated Show resolved Hide resolved
CHANGELOG.D/3137.feature Outdated Show resolved Hide resolved
CHANGELOG.D/3137.feature Outdated Show resolved Hide resolved
asvetlov
asvetlov approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@parikls parikls merged commit ddcc4d9 into master Dec 4, 2024
19 of 34 checks passed
@parikls parikls deleted the ENG-486-new-admin-cmds-for-org-user-credits branch December 4, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@zubenkoivan zubenkoivan Awaiting requested review from zubenkoivan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parikls @asvetlov