Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename http_port to http as it is in neuro-cli #309

Closed
atemate opened this issue Mar 11, 2021 · 2 comments
Closed

Rename http_port to http as it is in neuro-cli #309

atemate opened this issue Mar 11, 2021 · 2 comments

Comments

@atemate
Copy link
Contributor

atemate commented Mar 11, 2021

Since we have neuro run ... --http 8080, it'd be nice to have the same name in yaml.

kind: live
jobs:
  server:
    image: python:3.7
    preset: cpu-small
    http_port: 8080
    bash: python -m http.server 8080

Very obscure error message:

$ neuro-flow run server
ERROR: while constructing a 'Base'
  in "/home/ay/github/temp/neuro-flow/.neuro/live.yaml", line 4, column 5
unexpected key 'http'
  in "/home/ay/github/temp/neuro-flow/.neuro/live.yaml", line 6, column 5
ERROR: Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x7fbf24810ed0>
@romasku
Copy link
Contributor

romasku commented Mar 19, 2021

I would suggest the opposite - how about adding the --http-port option to neuro-cli and (maybe) deprecating the --http option. @asvetlov, what do you think about it?

The error message is indeed obscure. I think we fixed the Unclosed client session is fixed in v21.3.3, are you using the latest version? The 'Base' will be replaced with 'JobBase'.

@romasku
Copy link
Contributor

romasku commented Jan 24, 2022

Fixed here neuro-inc/apolo-cli#2501

@romasku romasku closed this as completed Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants