Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support projects in URI parsing #2956

Closed
YevheniiSemendiak opened this issue Apr 17, 2023 · 2 comments · Fixed by #2968
Closed

Support projects in URI parsing #2956

YevheniiSemendiak opened this issue Apr 17, 2023 · 2 comments · Fixed by #2968
Assignees
@andriihomiak

Comments

@YevheniiSemendiak
Copy link
Contributor

YevheniiSemendiak commented Apr 17, 2023 •
edited
Loading

As suggested in #2955, having functions for parsing platform resources URIs, we need to patch and adapt them to support project names.
Part of https://github.com/neuro-inc/no-code/issues/77

https://github.com/neuro-inc/neuro-cli/pull/2960/files#diff-0643a0bc73c408c16b7c497f766bdd264dddaf5767b553720067af7196d75dbfR36
@andriihomiak andriihomiak self-assigned this May 2, 2023
@andriihomiak andriihomiak mentioned this issue May 2, 2023
Closed
@andriihomiak
Copy link
Contributor

@YevheniiSemendiak this seems to be at least somewhat handled in #2960 (diff). Is there something more to do?

@YevheniiSemendiak
Copy link
Contributor Author

some of those places were covered in my PR, others were covered in #2961
I would suggest double-checking as the last step we did not forget smth.

@andriihomiak andriihomiak mentioned this issue May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andriihomiak andriihomiak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Pass project name instead of username when normalizing/parsing uri neuro-inc/apolo-cli
2 participants
@YevheniiSemendiak @andriihomiak