Print the status of finished jobs #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `neuro run`, `neuro attach`, `neuro logs`, `neuro exec` in non-quiet mode print now a line with the status of finished job. It helps to notice jobs terminated by the OOM Killer and cancelled jobs. * `neuro attach` to finished job now prints its status instead of "Job is running ..." * Job start progress now correctly handles statuses SUSPENDED, CANCELLED, UNKNOWN.
5 tasks
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #2801 +/- ##
===========================================
- Coverage 84.65% 73.47% -11.19%
===========================================
Files 72 70 -2
Lines 12429 12258 -171
Branches 2123 2119 -4
===========================================
- Hits 10522 9006 -1516
- Misses 1493 2941 +1448
+ Partials 414 311 -103
Continue to review full report at Codecov.
|
serhiy-storchaka
force-pushed
the
ss/print-job-result
branch
from
7e46751 to
ae02d65
Compare
asvetlov
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neuro run,neuro attach,neuro logs,neuro execin non-quietmode now print a line with the status of finished job. It helps to notice
jobs terminated by the OOM Killer and cancelled jobs.
neuro attachto finished job now prints its status instead of"Job is running ..."
CANCELLED, UNKNOWN.