Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken e2e test on Windows #1258

Closed
asvetlov opened this issue Dec 18, 2019 · 5 comments
Closed

Fix broken e2e test on Windows #1258

asvetlov opened this issue Dec 18, 2019 · 5 comments
Assignees
@anayden
Labels
bug Something isn't working CLIents platform

Comments

@asvetlov
Copy link
Contributor

asvetlov commented Dec 18, 2019 •
edited
Loading

Was introduced by #1254
@anayden, please fix ASAP
@asvetlov asvetlov added the bug Something isn't working label Dec 18, 2019
@anayden anayden mentioned this issue Dec 18, 2019
Closed
@serhiy-storchaka
Copy link
Contributor

Could you please show a traceback or a link to test logs?

@anayden
Copy link
Contributor

anayden commented Dec 18, 2019

https://dev.azure.com/neuromation/platform-client-python/_build/results?buildId=1732&view=logs&j=45f448c1-7a4d-56c6-196a-86747a444dcb&t=001c8d1e-0187-5d04-7be3-da6113fdc37c

@serhiy-storchaka
Copy link
Contributor

The cookiecutter-neuro-project project contains directory {{cookiecutter.project_slug}}. Is it valid filename on Windows?

@anayden
Copy link
Contributor

anayden commented Dec 18, 2019

This is a standard directory for cookiecutter projects, so I would be surprised if it wasn't compatible with windows.

In addition to that, there were successful runs of project init yesterday on Windows:

For instance:
https://dev.azure.com/neuromation/platform-client-python/_build/results?buildId=1711&view=logs&j=e28cd8f8-d7e3-5aff-d80c-3da2a1487608&t=9efd1b7e-57a6-5945-b49c-d40b7e15d911

And:
https://dev.azure.com/neuromation/platform-client-python/_build/results?buildId=1711&view=logs&j=d9e7689b-8c30-5683-b74c-3e8cb162cd9e&t=1eb63231-203d-526e-25da-41042709fdcb

@anayden
Copy link
Contributor

anayden commented Dec 23, 2019

Fixed by #1260

@anayden anayden closed this as completed Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anayden anayden

Labels
bug Something isn't working CLIents platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tests and rename the key for project init neuro-inc/apolo-cli
4 participants
@anayden @asvetlov @astaff @serhiy-storchaka