-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
activation ordering #2316
base: main
Are you sure you want to change the base?
activation ordering #2316
Conversation
As it relates to the serialization of act_reordering in [ note: I know this is unrelated to this PR ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have some (manual) tests in place for this as well? It's a subtle modification of the behavior, it would be great to have tested one way or another.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a unit test that tests the perplexity for oneshot done with this flag?
Activation Ordering implementation.
Checked lm_eval value with
actorder=True