-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribute migration script #137
Comments
Yes! Actually I thought I already suggested that to @AlanStorm, but I cant find my tweet... Some thing I saw: The script does not export different labels per store. So it might be an idea to generate such calls: http://stackoverflow.com/a/16421888/288568 |
Great, I'll start working on it then and let you know when I am done. I will also look into issue you mentioned. |
I will be absent until Sunday, just wanted to let you know that I am working on this. When I finish everything I will submit my pull request. You can check my progress so far on: |
@ldusan84 Thanks for implementing this. It's a very useful feature. If you are ready send me a pull request for the |
@amenk No problem, I'll let you know when I am done. I plan to include customer attributes support and write some tests. Let me know if you have some ideas regarding code organization. Maybe this script should not be in "dev" group of commands and things like that. |
I just added an option --update-script to config:get. Actually we should think about making an attribute-info command which displays the information easly readable and add the --update-script option for printing the migration script - what do you think? But we can sure also refactor that later in case more attribute-info functionality is added. |
I think that's a good idea, I can do it. Would you like me to create another branch for it? |
it's basically up to you and depends how much rework is needed. I think it should be pretty simple so that could be done in the same branch and directly released as that command. |
FYI: Doing a major GitHub re-organization. If you need to reference the original script, you can do so here https://github.com/astorm/MagentoAttributeMigrationGenerate |
@astorm Thanks for the hint. |
I think this ticket can be closed since we now have dev:setup:script:attribute. |
I would like to port attribute migration script from https://github.com/astorm/Pulsestorm/blob/master/magento-create-setup.php
Do you think it would be a useful addition?
The text was updated successfully, but these errors were encountered: