Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing tests folder for cisco_ios_show_ip_bgp #74

Closed
jmcgill298 opened this issue Jan 11, 2017 · 3 comments
Closed

missing tests folder for cisco_ios_show_ip_bgp #74

jmcgill298 opened this issue Jan 11, 2017 · 3 comments

Comments

@jmcgill298
Copy link
Contributor

ISSUE TYPE
  • Missing Files
TEMPLATE USING
cisco_ios_show_ip_bgp
SUMMARY

The folder containing the raw and parsed files is missing.
@wintermute000 do you have these files? Are you on the networktocode slack channel?

@wintermute000
Copy link
Contributor

Hi jmcgill298

unfortunately I was testing/writing the code using customer output. I can't share them, but you can run the code against any example and see for yourself.

note I'm still not sure its 100% correct as I didn't do a line by line comparison of over 10k routes but from the data that I was comparing it seemed to do the job. It definitely handles a TON more corner cases than the initial code.

Sorry I'm not in that slack, happy to join, though I'm just a dabbler.

@sjtarik
Copy link
Contributor

sjtarik commented Jan 12, 2017

Hi @wintermute000,

Why don't you anonymize it? You can replace Ip patterns with some non-routable ones, mac addresses with random mac combinations and remove all resolved URL addresses. I have a simple hack script doing that before posting tests. Maybe we should include something like that in project.

Best,
Tarik

@wintermute000
Copy link
Contributor

How about these? I just took the example from the Cisco textbook.

example.txt
output.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants