-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify None handling for configuration parsing #126
Comments
Also applicable to |
@jmcgill298 any chance you can take a look? |
The references to netutils/netutils/config/parser.py Lines 187 to 189 in e757bfe
The references to netutils/netutils/config/parser.py Lines 222 to 224 in e757bfe
The references to The reference to I suspect that the last two methods had a return to simplify writing test cases |
BaseSpaceConfigParser.build_config_relationship
is using multiple._build_$something
methods that currently return anOptional[str]
. It is not clear what happens, if one of those actually returnsNone
. We should decide on whether we want to raise an exception in those specific methods or pass the None up the chain and handle it there. In any case, it needs to be handled to get rid of all the# type: ignore
comments.Originally posted by @Kircheneer in #123 (comment)
The text was updated successfully, but these errors were encountered: