Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sdk/pkg/tools/pprof #1654

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Add sdk/pkg/tools/pprof #1654

merged 2 commits into from
Aug 8, 2024

Conversation

Ex4amp1e
Copy link
Contributor

@Ex4amp1e Ex4amp1e commented Aug 8, 2024

Description

Add sdk/pkg/tools/pprof

Issue link

networkservicemesh/deployments-k8s#12045

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

Add sdk/pkg/tools/pprof
f8ce701 
Signed-off-by: Vladislav Byrgazov <[email protected]>
@Ex4amp1e Ex4amp1e marked this pull request as draft August 8, 2024 09:24
denis-tingaikin
denis-tingaikin reviewed Aug 8, 2024
View reviewed changes
pkg/tools/pprof/pprof.go Outdated
)

// Init - configures pprof http handlers
func Init(ctx context.Context, port string) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func Init(ctx context.Context, port string) {
func Init(ctx context.Context, port uint16) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Address review comments
660c766 
Signed-off-by: Vladislav Byrgazov <[email protected]>
@Ex4amp1e Ex4amp1e marked this pull request as ready for review August 8, 2024 10:59
@Ex4amp1e Ex4amp1e requested a review from NikitaSkrynnik August 8, 2024 11:05
@denis-tingaikin denis-tingaikin merged commit ce2c8f5 into networkservicemesh:main Aug 8, 2024
15 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d4d1f6b 
…k@main

PR link: networkservicemesh/sdk#1654

Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
  - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof

Signed-off-by: Vladislav Byrgazov <[email protected]>

* Address review comments

Signed-off-by: Vladislav Byrgazov <[email protected]>

---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3e6f370 
…k@main

PR link: networkservicemesh/sdk#1654

Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
  - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof

Signed-off-by: Vladislav Byrgazov <[email protected]>

* Address review comments

Signed-off-by: Vladislav Byrgazov <[email protected]>

---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
47ddd37 
…k@main

PR link: networkservicemesh/sdk#1654

Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
  - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof

Signed-off-by: Vladislav Byrgazov <[email protected]>

* Address review comments

Signed-off-by: Vladislav Byrgazov <[email protected]>

---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a12bd54 
…k@main

PR link: networkservicemesh/sdk#1654

Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
  - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof

Signed-off-by: Vladislav Byrgazov <[email protected]>

* Address review comments

Signed-off-by: Vladislav Byrgazov <[email protected]>

---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2dfe146 
…k@main

PR link: networkservicemesh/sdk#1654

Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
  - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof

Signed-off-by: Vladislav Byrgazov <[email protected]>

* Address review comments

Signed-off-by: Vladislav Byrgazov <[email protected]>

---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
615dbf7 
…k@main

PR link: networkservicemesh/sdk#1654

Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
  - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof

Signed-off-by: Vladislav Byrgazov <[email protected]>

* Address review comments

Signed-off-by: Vladislav Byrgazov <[email protected]>

---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1ccac03 
…k@main

PR link: networkservicemesh/sdk#1654

Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
  - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof

Signed-off-by: Vladislav Byrgazov <[email protected]>

* Address review comments

Signed-off-by: Vladislav Byrgazov <[email protected]>

---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c3736f5 
…k@main

PR link: networkservicemesh/sdk#1654

Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
  - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof

Signed-off-by: Vladislav Byrgazov <[email protected]>

* Address review comments

Signed-off-by: Vladislav Byrgazov <[email protected]>

---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-dashboard-backend that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0b8dbe5 
…k@main

PR link: networkservicemesh/sdk#1654

Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
  - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof

Signed-off-by: Vladislav Byrgazov <[email protected]>

* Address review comments

Signed-off-by: Vladislav Byrgazov <[email protected]>

---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8c93052 
…k@main

PR link: networkservicemesh/sdk#1654

Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
  - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof

Signed-off-by: Vladislav Byrgazov <[email protected]>

* Address review comments

Signed-off-by: Vladislav Byrgazov <[email protected]>

---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
7d1a25f 
…k@main

PR link: networkservicemesh/sdk#1654

Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
  - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof

Signed-off-by: Vladislav Byrgazov <[email protected]>

* Address review comments

Signed-off-by: Vladislav Byrgazov <[email protected]>

---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
597215a 
…k@main

PR link: networkservicemesh/sdk#1654

Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
  - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof

Signed-off-by: Vladislav Byrgazov <[email protected]>

* Address review comments

Signed-off-by: Vladislav Byrgazov <[email protected]>

---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
34581ff 
…k@main

PR link: networkservicemesh/sdk#1654

Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
  - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof

Signed-off-by: Vladislav Byrgazov <[email protected]>

* Address review comments

Signed-off-by: Vladislav Byrgazov <[email protected]>

---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0817adb 
…k@main

PR link: networkservicemesh/sdk#1654

Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
  - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof

Signed-off-by: Vladislav Byrgazov <[email protected]>

* Address review comments

Signed-off-by: Vladislav Byrgazov <[email protected]>

---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
This was referenced Aug 8, 2024
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2d44ebe 
…k@main

PR link: networkservicemesh/sdk#1654

Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
  - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof

Signed-off-by: Vladislav Byrgazov <[email protected]>

* Address review comments

Signed-off-by: Vladislav Byrgazov <[email protected]>

---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
This was referenced Aug 8, 2024
Merged
Merged
Merged
Merged
Merged
nsmbot added a commit to networkservicemesh/sdk-k8s that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8fb8c88 
…k@main (#515)

PR link: networkservicemesh/sdk#1654

Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
  - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof



* Address review comments



---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5e4aa8e 
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#515

Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
    - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------
Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-exclude-prefixes-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
7966b06 
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#515

Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
    - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------
Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-ovs that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
226bf75 
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#515

Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
    - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------
Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-registry-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2e435b6 
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#515

Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
    - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------
Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-sriov that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
de6a1db 
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#515

Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
    - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------
Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-vpp that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
06d5824 
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#515

Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
    - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------
Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-supplier-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b5f5193 
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#515

Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
    - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------
Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot added a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
67ffe44 
…k-k8s@main (#445)

PR link: networkservicemesh/sdk-k8s#515

Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
    - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot added a commit to networkservicemesh/cmd-registry-k8s that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
eaa1647 
…k-k8s@main (#469)

PR link: networkservicemesh/sdk-k8s#515

Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
    - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot added a commit to networkservicemesh/cmd-exclude-prefixes-k8s that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
be019c3 
…k-k8s@main (#304)

PR link: networkservicemesh/sdk-k8s#515

Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
    - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot added a commit to networkservicemesh/cmd-forwarder-sriov that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
310484b 
…k-k8s@main (#754)

PR link: networkservicemesh/sdk-k8s#515

Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
    - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
5bc2836 
…d-admission-webhook-k8s@main

PR link: networkservicemesh/cmd-admission-webhook-k8s#445

Commit: 67ffe44
Author: Network Service Mesh Bot
Date: 2024-08-08 09:49:29 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#445)
PR link: networkservicemesh/sdk-k8s#515
Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
        - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------
Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
1eafc2c 
…d-exclude-prefixes-k8s@main

PR link: networkservicemesh/cmd-exclude-prefixes-k8s#304

Commit: be019c3
Author: Network Service Mesh Bot
Date: 2024-08-08 09:49:37 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#304)
PR link: networkservicemesh/sdk-k8s#515
Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
        - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------
Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
e048030 
…d-registry-k8s@main

PR link: networkservicemesh/cmd-registry-k8s#469

Commit: eaa1647
Author: Network Service Mesh Bot
Date: 2024-08-08 09:49:37 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#469)
PR link: networkservicemesh/sdk-k8s#515
Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
        - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------
Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
baf5654 
…d-forwarder-sriov@main

PR link: networkservicemesh/cmd-forwarder-sriov#754

Commit: 310484b
Author: Network Service Mesh Bot
Date: 2024-08-08 09:49:43 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#754)
PR link: networkservicemesh/sdk-k8s#515
Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
        - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------
Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this pull request Aug 8, 2024
Merged
nsmbot added a commit to networkservicemesh/cmd-nse-supplier-k8s that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f8ac83a 
…k-k8s@main (#340)

PR link: networkservicemesh/sdk-k8s#515

Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
    - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot added a commit to networkservicemesh/cmd-forwarder-ovs that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f312d37 
…k-k8s@main (#394)

PR link: networkservicemesh/sdk-k8s#515

Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
    - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
e8dbf0f 
…d-nse-supplier-k8s@main

PR link: networkservicemesh/cmd-nse-supplier-k8s#340

Commit: f8ac83a
Author: Network Service Mesh Bot
Date: 2024-08-08 09:50:12 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#340)
PR link: networkservicemesh/sdk-k8s#515
Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
        - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------
Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
5360d37 
…d-forwarder-ovs@main

PR link: networkservicemesh/cmd-forwarder-ovs#394

Commit: f312d37
Author: Network Service Mesh Bot
Date: 2024-08-08 09:50:14 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#394)
PR link: networkservicemesh/sdk-k8s#515
Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
        - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------
Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this pull request Aug 8, 2024
Merged
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
4556b59 
…d-admission-webhook-k8s@main (#12145)

PR link: networkservicemesh/cmd-admission-webhook-k8s#445

Commit: 67ffe44
Author: Network Service Mesh Bot
Date: 2024-08-08 09:49:29 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#445)
PR link: networkservicemesh/sdk-k8s#515
Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
        - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
b9aef5a 
…d-registry-k8s@main (#12053)

PR link: networkservicemesh/cmd-registry-k8s#469

Commit: eaa1647
Author: Network Service Mesh Bot
Date: 2024-08-08 09:49:37 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#469)
PR link: networkservicemesh/sdk-k8s#515
Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
        - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
f2a947b 
…d-forwarder-sriov@main (#12163)

PR link: networkservicemesh/cmd-forwarder-sriov#754

Commit: 310484b
Author: Network Service Mesh Bot
Date: 2024-08-08 09:49:43 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#754)
PR link: networkservicemesh/sdk-k8s#515
Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
        - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 8, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
47da7c2 
…d-forwarder-ovs@main (#12168)

PR link: networkservicemesh/cmd-forwarder-ovs#394

Commit: f312d37
Author: Network Service Mesh Bot
Date: 2024-08-08 09:50:14 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#394)
PR link: networkservicemesh/sdk-k8s#515
Commit: 8fb8c88
Author: Network Service Mesh Bot
Date: 2024-08-08 09:46:02 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#515)
PR link: networkservicemesh/sdk#1654
Commit: ce2c8f5
Author: Vladislav Byrgazov
Date: 2024-08-08 16:34:33 +0500
Message:
        - Add sdk/pkg/tools/pprof (#1654)
* Add sdk/pkg/tools/pprof
* Address review comments
---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: NSMBot <[email protected]>
Co-authored-by: NSMBot <[email protected]>
denis-tingaikin
denis-tingaikin reviewed Aug 9, 2024
View reviewed changes
pkg/tools/pprof/pprof.go
)

// Init - configures pprof http handlers
func Init(ctx context.Context, port uint16) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Init -> ListenAndServe
port -> listenOn url.Url

@Ex4amp1e Ex4amp1e mentioned this pull request Aug 12, 2024
Merged
9 tasks
denis-tingaikin pushed a commit that referenced this pull request Sep 17, 2024
@Ex4amp1e @denis-tingaikin
Add sdk/pkg/tools/pprof (#1654)
74cca57 
* Add sdk/pkg/tools/pprof

Signed-off-by: Vladislav Byrgazov <[email protected]>

* Address review comments

Signed-off-by: Vladislav Byrgazov <[email protected]>

---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Co-authored-by: Vladislav Byrgazov <[email protected]>
denis-tingaikin pushed a commit that referenced this pull request Sep 17, 2024
@Ex4amp1e @denis-tingaikin
Add sdk/pkg/tools/pprof (#1654)
6c458ac 
* Add sdk/pkg/tools/pprof

Signed-off-by: Vladislav Byrgazov <[email protected]>

* Address review comments

Signed-off-by: Vladislav Byrgazov <[email protected]>

---------

Signed-off-by: Vladislav Byrgazov <[email protected]>
Co-authored-by: Vladislav Byrgazov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@NikitaSkrynnik NikitaSkrynnik Awaiting requested review from NikitaSkrynnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ex4amp1e @denis-tingaikin