begin: update context after a successful request #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <[email protected]>
glazychev-art
force-pushed
the
begin_updatecontext
branch
from
3a83c8f to
db42a65
Compare
denis-tingaikin
approved these changes
Oct 13, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Oct 13, 2022
…k@main PR link: networkservicemesh/sdk#1370 Commit: 9ae27f8 Author: Artem Glazychev Date: 2022-10-13 15:25:56 +0700 Message: - begin: update context after a successful request (#1370) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Oct 13, 2022
…k@main PR link: networkservicemesh/sdk#1370 Commit: 9ae27f8 Author: Artem Glazychev Date: 2022-10-13 15:25:56 +0700 Message: - begin: update context after a successful request (#1370) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Oct 13, 2022
…k@main PR link: networkservicemesh/sdk#1370 Commit: 9ae27f8 Author: Artem Glazychev Date: 2022-10-13 15:25:56 +0700 Message: - begin: update context after a successful request (#1370) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Oct 13, 2022
…k@main PR link: networkservicemesh/sdk#1370 Commit: 9ae27f8 Author: Artem Glazychev Date: 2022-10-13 15:25:56 +0700 Message: - begin: update context after a successful request (#1370) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Oct 13, 2022
…k@main PR link: networkservicemesh/sdk#1370 Commit: 9ae27f8 Author: Artem Glazychev Date: 2022-10-13 15:25:56 +0700 Message: - begin: update context after a successful request (#1370) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Oct 13, 2022
…k@main PR link: networkservicemesh/sdk#1370 Commit: 9ae27f8 Author: Artem Glazychev Date: 2022-10-13 15:25:56 +0700 Message: - begin: update context after a successful request (#1370) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Oct 13, 2022
…k@main PR link: networkservicemesh/sdk#1370 Commit: 9ae27f8 Author: Artem Glazychev Date: 2022-10-13 15:25:56 +0700 Message: - begin: update context after a successful request (#1370) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Oct 13, 2022
…k@main PR link: networkservicemesh/sdk#1370 Commit: 9ae27f8 Author: Artem Glazychev Date: 2022-10-13 15:25:56 +0700 Message: - begin: update context after a successful request (#1370) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Oct 13, 2022
…k@main PR link: networkservicemesh/sdk#1370 Commit: 9ae27f8 Author: Artem Glazychev Date: 2022-10-13 15:25:56 +0700 Message: - begin: update context after a successful request (#1370) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Oct 13, 2022
…k@main PR link: networkservicemesh/sdk#1370 Commit: 9ae27f8 Author: Artem Glazychev Date: 2022-10-13 15:25:56 +0700 Message: - begin: update context after a successful request (#1370) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Oct 13, 2022
…k@main PR link: networkservicemesh/sdk#1370 Commit: 9ae27f8 Author: Artem Glazychev Date: 2022-10-13 15:25:56 +0700 Message: - begin: update context after a successful request (#1370) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Oct 13, 2022
…k@main PR link: networkservicemesh/sdk#1370 Commit: 9ae27f8 Author: Artem Glazychev Date: 2022-10-13 15:25:56 +0700 Message: - begin: update context after a successful request (#1370) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Oct 13, 2022
…k@main PR link: networkservicemesh/sdk#1370 Commit: 9ae27f8 Author: Artem Glazychev Date: 2022-10-13 15:25:56 +0700 Message: - begin: update context after a successful request (#1370) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
This was referenced Oct 13, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Oct 16, 2022
…k@main PR link: networkservicemesh/sdk#1370 Commit: 9ae27f8 Author: Artem Glazychev Date: 2022-10-13 15:25:56 +0700 Message: - begin: update context after a successful request (#1370) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Oct 16, 2022
…k@main PR link: networkservicemesh/sdk#1370 Commit: 9ae27f8 Author: Artem Glazychev Date: 2022-10-13 15:25:56 +0700 Message: - begin: update context after a successful request (#1370) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Glazychev [email protected]
Description
We should update the eventFactory context only after successful refresh.
The reason: we update eventFactory request only if we don't have an error - https://github.com/networkservicemesh/sdk/blob/main/pkg/networkservice/common/begin/server.go#L75-L77
Thus, if we update the context before the request and it fails, we will have the wrong state (new context but previous request)
Issue link
#1357
How Has This Been Tested?
Types of changes