-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of deprecated grpc options #1455
Comments
It looks like |
I think we need get rid of using deperecated options |
Current StateWe found that there are only a few cases where NSM doesn't work without Without This article explains this |
Expected Behavior
All applications use the same grpc options
Current Behavior
Some cmds use a different set of options
Failure Information (for bugs)
Need to figure out how grpc.WaitForReady() works (and possibly delete it), add tracing interceptors.
We have to check
networkservice
andregistry
chains.Example of correct option sets.
Client:
https://github.com/networkservicemesh/cmd-nsmgr/blob/3767a9554e633ace231e600512354740071f5519/internal/manager/manager.go#L134-L146
Server:
https://github.com/networkservicemesh/cmd-nsmgr/blob/3767a9554e633ace231e600512354740071f5519/internal/manager/manager.go#L159-L166
Context
Failure Logs
The text was updated successfully, but these errors were encountered: