-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve reliability of chain element 'etcd' #523
Conversation
Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: denis-tingaikin <[email protected]>
Signed-off-by: denis-tingaikin <[email protected]>
I wonder when using sdk/pkg/registry/core/chain's NewNetworkServiceEndpointRegistryClient to get a client to watch NSEs that belong to a particular NS, how should one avoid missing Delete events in case loss of nsmgr or registry handling the find? (Assuming the NSE registration/unregistration is served by a different registry and nsmgr.) |
True, and since it's related to the client side, I've created a separate ticket to consider the problem on the client side networkservicemesh/sdk#1671 |
9d47fa1
to
f2c0123
Compare
Signed-off-by: denis-tingaikin <[email protected]>
f2c0123
to
c20c735
Compare
Signed-off-by: denis-tingaikin <[email protected]>
…k-k8s@main PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]>
…k-k8s@main PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]>
…k-k8s@main PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]>
…k-k8s@main PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]>
…k-k8s@main PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]>
…k-k8s@main PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]>
…k-k8s@main PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]>
…k-k8s@main (#478) PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
…k-k8s@main (#352) PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
…k-k8s@main (#461) PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
…k-k8s@main (#316) PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
…d-registry-k8s@main PR link: networkservicemesh/cmd-registry-k8s#478 Commit: e16db2b Author: Network Service Mesh Bot Date: 2024-09-24 09:56:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#478) PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]>
…k-k8s@main (#770) PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
…k-k8s@main (#412) PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
…d-admission-webhook-k8s@main PR link: networkservicemesh/cmd-admission-webhook-k8s#461 Commit: 8f127de Author: Network Service Mesh Bot Date: 2024-09-24 09:57:05 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#461) PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]>
…d-exclude-prefixes-k8s@main PR link: networkservicemesh/cmd-exclude-prefixes-k8s#316 Commit: 897150e Author: Network Service Mesh Bot Date: 2024-09-24 09:57:09 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#316) PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]>
…d-nse-supplier-k8s@main PR link: networkservicemesh/cmd-nse-supplier-k8s#352 Commit: 30a07ff Author: Network Service Mesh Bot Date: 2024-09-24 09:57:05 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#352) PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]>
…d-forwarder-sriov@main PR link: networkservicemesh/cmd-forwarder-sriov#770 Commit: d1996c2 Author: Network Service Mesh Bot Date: 2024-09-24 09:57:11 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#770) PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]>
…d-forwarder-ovs@main PR link: networkservicemesh/cmd-forwarder-ovs#412 Commit: 35f6d5e Author: Network Service Mesh Bot Date: 2024-09-24 09:57:13 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#412) PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]>
…d-nse-supplier-k8s@main (#12303) PR link: networkservicemesh/cmd-nse-supplier-k8s#352 Commit: 30a07ff Author: Network Service Mesh Bot Date: 2024-09-24 09:57:05 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#352) PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
…d-registry-k8s@main (#12314) PR link: networkservicemesh/cmd-registry-k8s#478 Commit: e16db2b Author: Network Service Mesh Bot Date: 2024-09-24 09:56:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#478) PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
…d-forwarder-sriov@main (#12313) PR link: networkservicemesh/cmd-forwarder-sriov#770 Commit: d1996c2 Author: Network Service Mesh Bot Date: 2024-09-24 09:57:11 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#770) PR link: networkservicemesh/sdk-k8s#523 Commit: e3a1092 Author: Ed Warnicke Date: 2024-09-24 09:53:20 -0500 Message: - Merge pull request #523 from networkservicemesh/reliable-watch Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
Built a k8s-registry on 1.13.2 for a quick try. For me its seems that register simply uses the nse returned by client.Get() for update instead of the one in the request, thus the expiration time won't be updated. |
Closes #512