Skip to content

Commit

Permalink
Update go.mod and go.sum to latest version from networkservicemesh/cm…
Browse files Browse the repository at this point in the history
…d-forwarder-vpp@main

PR link: networkservicemesh/cmd-forwarder-vpp#739

Commit: a2c0b6d
Author: Ed Warnicke
Date: 2022-10-25 02:59:01 -0500
Message:
  - Final fix to disable IPv6 RA when NSM_TUNNEL_IP is IPv6 (#739)
VPP, being a router, presumes that any IPv6 enabled interface should,
by default, be sending IPv6 Router Announcements (RAs).

In our case, this is an incorrect behavior.

In the past we had attempted using:

'ip6 nd host-%s ra-cease'

this did not work as expected for two reasons:

1.  It was done before assigning an IPv6 address to the interface.
    Because of this the interface does not yet have IPv6 enabled,
    and therefore the 'ip6 nd host-%s ra-cease' has no effect.
2.  'ip6 nd host-%s ra-cease' only precluded repetition of RAs
    after the interface is up.  Initial RAs are still sent.
    This can be fixed by adding 'ra-suppress'

So in short, we use:
'enable ip6 interface host-%s'
'ip6 nd host-%s ra-cease ra-suppress'

which disables any sending of RAs from the interface prior to it
being 'upped'.

This has been tested using tcpdump. Tcpdump was used in the uncorrected
case to ensure it correctly detects RAs being sent out (it does)
Tcpdump was used to determine that with:

'enable ip6 interface host-%s'
'ip6 nd host-%s ra-cease'

the initial RA is sent, but no subsequent RAs.

The actual fix was tested with tcpdump to ensure that

'enable ip6 interface host-%s'
'ip6 nd host-%s ra-cease ra-suppress'

results in *no* RAs being sent.

Finally, tcpdump was used to ensure that with the code being submitted
was used, not RAs were sent out.

Signed-off-by: Ed Warnicke <[email protected]>
Signed-off-by: NSMBot <[email protected]>
  • Loading branch information
NSMBot committed Oct 25, 2022
1 parent a9a3447 commit 948f848
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion apps/forwarder-vpp/forwarder.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
hostNetwork: true
dnsPolicy: ClusterFirstWithHostNet
containers:
- image: ghcr.io/networkservicemesh/ci/cmd-forwarder-vpp:e7946bb
- image: ghcr.io/networkservicemesh/ci/cmd-forwarder-vpp:a2c0b6d
imagePullPolicy: IfNotPresent
name: forwarder-vpp
securityContext:
Expand Down
2 changes: 1 addition & 1 deletion examples/features/select-forwarder/forwarder.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
hostNetwork: true
dnsPolicy: ClusterFirstWithHostNet
containers:
- image: ghcr.io/networkservicemesh/ci/cmd-forwarder-vpp:e7946bb
- image: ghcr.io/networkservicemesh/ci/cmd-forwarder-vpp:a2c0b6d
imagePullPolicy: IfNotPresent
name: my-forwarder-vpp
securityContext:
Expand Down

0 comments on commit 948f848

Please sign in to comment.