Test envcheck. #625
Closed
Test envcheck. #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arp-est
force-pushed
the
arpest_test_envcheck
branch
5 times, most recently
from
56c57c0 to
2ed98f5
Compare
Signed-off-by: Arpad Kiss <[email protected]>
arp-est
force-pushed
the
arpest_test_envcheck
branch
from
2ed98f5 to
50d661e
Compare
denis-tingaikin
approved these changes
Apr 16, 2024
Comment on lines
+41
to
+45
| * NSM_LIVENESSCHECKENABLED - Dataplane liveness check enabled/disabled | ||
| * NSM_LIVENESSCHECKINTERVAL - Dataplane liveness check interval | ||
| * NSM_LIVENESSCHECKTIMEOUT - Dataplane liveness check timeout | ||
| * NSM_LOCALDNSSERVERADDRESS - Default address for local DNS server | ||
| * NSM_LOCALDNSSERVERENABLED - Local DNS Server enabled/disabled |
There was a problem hiding this comment.
As I can see, we also missed split_words:"true" in some environment names.
I think it can also be improved and updated.
Then, for example, instead of NSM_LIVENESSCHECKENABLED we will use NSM_LIVENESS_CHECK_ENABLED that looks clearer.
nsmbot
pushed a commit
that referenced
this pull request
Nov 26, 2024
…k-sriov@main PR link: networkservicemesh/sdk-sriov#625 Commit: f52c0d7 Author: Network Service Mesh Bot Date: 2024-11-26 03:12:46 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#625) PR link: networkservicemesh/sdk-kernel#697 Commit: 89a3b43 Author: Network Service Mesh Bot Date: 2024-11-26 03:08:35 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#697) PR link: networkservicemesh/sdk#1585 Commit: 35e15a4 Author: Nikita Skrynnik Date: 2024-11-26 20:06:10 +1100 Message: - Add an option to change reselect function (#1585) * Add mutable reselect function * fix go linter issues * add a test with custom reselect function * revert changes in liveness check ctx * pass reselectFunc through client * cleanup * fix linter issues * fix linter issues * fix test * Fix review comments * fix CI issues * add vl3 reselect function * rename reselect function --------- Signed-off-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.