Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep env var descriptions in sync in cmd and README.md #65

Closed
arp-est opened this issue Mar 14, 2024 · 5 comments
Closed

Keep env var descriptions in sync in cmd and README.md #65

arp-est opened this issue Mar 14, 2024 · 5 comments
Assignees

Comments

@arp-est
Copy link
Contributor

arp-est commented Mar 14, 2024

Goal is to have something that checks whether the envs in the README match the ones described by the cmd.

@arp-est
Copy link
Contributor Author

arp-est commented Apr 19, 2024

Hi,
Added the pr-s to cmd-template, and k8s-deployment too.

networkservicemesh/cmd-registry-memory#661
networkservicemesh/deployments-k8s#11877
networkservicemesh/cmd-template#131

@arp-est
Copy link
Contributor Author

arp-est commented Apr 24, 2024

Hi,
Updated the cmd-s, fixed the bug in .github/scripts/env-check.sh, and updated the env vars that were changed in deployments-k8s.

Pull Requests:

#76
networkservicemesh/cmd-admission-webhook-k8s#421
networkservicemesh/cmd-cluster-info-k8s#129
networkservicemesh/cmd-csi-driver#64
networkservicemesh/cmd-exclude-prefixes-k8s#293
networkservicemesh/cmd-forwarder-ovs#370
networkservicemesh/cmd-forwarder-sriov#731
networkservicemesh/cmd-forwarder-vpp#1105
networkservicemesh/cmd-ipam-vl3#196
networkservicemesh/cmd-lb-vl3-vpp#73
networkservicemesh/cmd-map-ip-k8s#218
networkservicemesh/cmd-nsc#627
networkservicemesh/cmd-nsc-init#741
networkservicemesh/cmd-nsc-simple-docker#224
networkservicemesh/cmd-nsc-vpp#690
networkservicemesh/cmd-nse-firewall-vpp#508
networkservicemesh/cmd-nse-icmp-responder#593
networkservicemesh/cmd-nse-icmp-responder-vpp#671
networkservicemesh/cmd-nse-l7-proxy#201
networkservicemesh/cmd-nse-remote-vlan#223
networkservicemesh/cmd-nse-simple-vl3-docker#237
networkservicemesh/cmd-nse-supplier-k8s#329
networkservicemesh/cmd-nse-vfio#514
networkservicemesh/cmd-nse-vl3-vpp#332
networkservicemesh/cmd-nse-vlan-vpp#467
networkservicemesh/cmd-nsmgr#677
networkservicemesh/cmd-nsmgr-proxy#496
networkservicemesh/deployments-k8s#11916

Envs that got split_words:"true" added:
(might include envs from deprecated repos, have to check it checked it, they're good)

NSM_ACL_CONFIG
NSM_BRIDGE_NAME
NSM_FEDERATES_WITH
NSM_INTERFACE_NAME
NSM_LIVENESS_CHECK_ENABLED
NSM_LIVENESS_CHECK_INTERVAL
NSM_LIVENESS_CHECK_TIMEOUT
NSM_LOCAL_DNS_SERVER_ADDRESS
NSM_LOCAL_DNS_SERVER_ENABLED
NSM_METRICS_EXPORT_INTERVAL
NSM_NODE_NAME
NSM_OPEN_TELEMETRY_ENDPOINT
NSM_OUTPUT_PATH
NSM_TRUST_DOMAIN
NSM_VL3_PREFIX

@denis-tingaikin
Copy link
Member

Great work, thanks!

It seems like a few repos are still remaining. Could you also have a look at https://github.com/networkservicemesh?q=registry-&type=all&language=&sort=?

@arp-est
Copy link
Contributor Author

arp-est commented May 14, 2024

Hi,
Sorry about that I forgot to create the pull request for those.
Here they are now:
networkservicemesh/cmd-registry-proxy-dns#647
networkservicemesh/cmd-registry-memory#666
networkservicemesh/cmd-registry-k8s#457 (I see that you already merged this one)

@denis-tingaikin
Copy link
Member

All good. Merged.

@arp-est arp-est closed this as completed Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants