Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diff readability with inline diff highlighting #321

Open
JanTvrdik opened this issue Jun 19, 2016 · 1 comment
Open

Improve diff readability with inline diff highlighting #321

JanTvrdik opened this issue Jun 19, 2016 · 1 comment

Comments

@JanTvrdik
Copy link
Contributor

The difference readability should be increased with inline diffs using probably the same style as https://github.com/git/git/tree/master/contrib/diff-highlight

image
@milo
Copy link
Member

milo commented Jun 30, 2016

I would stay with yellow. IMHO, when showing diff, there is no reason for red/green. Cannot say old/new, correct/wrong because maybe test needs to be updated.

The inverse of difference may look nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JanTvrdik @milo