Fix incorrect bool expressions behavior due to params_lookup() behavi… #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or and puppet 3.7+ changes - make string comparisons with a constant value of ''. The semantics of empty strings has changed in the later versions of puppet. Empty strings are now considered always true. Since params_lookup always returns an empty string for undef values, this causes a reverse logic behavior of the entire class. - change default value of fail2ban::noop parameter to false (not undef) for the same reasons as above. params_lookup would turn an undef to '', which in turn means true in puppet 3.7+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or and puppet 3.7+ changes
of empty strings has changed in the later versions of puppet. Empty
strings are now considered always true. Since params_lookup always
returns an empty string for undef values, this causes a reverse
logic behavior of the entire class.
undef) for the same reasons as above. params_lookup would turn an
undef to '', which in turn means true in puppet 3.7+