feat: ratelimit config from source #1714

paulo · 2024-03-01T11:46:09Z

Summary

Related to ADN-294

Adds ratelimit info to the functions manifest so we can create per-deploy rate limit rules from the source code. Please review this code ruthlessly and nitpick everything you can, my ts-fu is not great and it's my first contribution to this codebase.

github-actions · 2024-03-01T11:47:36Z

⏱ Benchmark results

Comparing with 51f5e9e

largeDepsEsbuild: 1.3s

⬆️ 0.18% increase vs. 51f5e9e

^   1.5s            1.5s                    1.5s                                                          
│   ┌──┐    1.4s    ┌──┐    1.4s    1.4s    ┌──┐    1.4s    1.5s    1.5s    1.4s                          
│ ──┼──┼────┌──┐────┼──┼────┌──┐────┌──┐────┼──┼────┌──┐────┌──┐────┌──┐────┌──┐──────────────────────────
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    1.3s    1.3s    1.3s  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (f146798): 1.4s
T-29 (c7901aa): 1.4s
T-28 (bc7b0b8): 1.5s
T-27 (81e451b): 1.4s
T-26 (daa74ff): 1.4s
T-25 (128b059): 1.4s
T-24 (f01af04): 1.5s
T-23 (44f2871): 1.4s
T-22 (a176e52): 1.5s
T-21 (897284e): 1.5s
T-20 (30703f8): 1.5s
T-19 (ec7bde9): 1.4s
T-18 (05b3c1a): 1.4s
T-17 (393b490): 1.5s
T-16 (abcba24): 1.4s
T-15 (1b10dd1): 1.5s
T-14 (46377da): 1.5s
T-13 (1a06dac): 1.4s
T-12 (8a3845d): 1.5s
T-11 (8ebae9d): 1.4s
T-10 (655f1a8): 1.5s
T-9 (64ee032): 1.4s
T-8 (f129ca1): 1.4s
T-7 (bd3bd46): 1.5s
T-6 (136119a): 1.4s
T-5 (9e82c5a): 1.5s
T-4 (db2f959): 1.5s
T-3 (ee501c7): 1.4s
T-2 (2c25489): 1.3s
T-1 (51f5e9e): 1.3s
T (current commit): 1.3s

largeDepsNft: 5.5s

⬇️ 2.48% decrease vs. 51f5e9e

^                           5.7s            5.7s            5.6s                            5.6s          
│           5.6s    5.5s    ┌──┐    5.5s    ┌──┐    5.4s    ┌──┐    5.5s    5.5s    5.6s    ┌──┐    5.5s  
│ ──5.3s────┌──┐────┌──┐────┼──┼────┌──┐────┼──┼────┌──┐────┼──┼────┌──┐────┌──┐────┌──┐────┼──┼────┌──┐──
│   ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (f146798): 5.5s
T-29 (c7901aa): 5.5s
T-28 (bc7b0b8): 5.6s
T-27 (81e451b): 5.5s
T-26 (daa74ff): 5.4s
T-25 (128b059): 5.7s
T-24 (f01af04): 5.5s
T-23 (44f2871): 5.6s
T-22 (a176e52): 5.8s
T-21 (897284e): 5.5s
T-20 (30703f8): 5.5s
T-19 (ec7bde9): 5.5s
T-18 (05b3c1a): 5.5s
T-17 (393b490): 5.6s
T-16 (abcba24): 5.5s
T-15 (1b10dd1): 5.8s
T-14 (46377da): 5.8s
T-13 (1a06dac): 5.6s
T-12 (8a3845d): 5.3s
T-11 (8ebae9d): 5.6s
T-10 (655f1a8): 5.5s
T-9 (64ee032): 5.7s
T-8 (f129ca1): 5.5s
T-7 (bd3bd46): 5.7s
T-6 (136119a): 5.4s
T-5 (9e82c5a): 5.6s
T-4 (db2f959): 5.5s
T-3 (ee501c7): 5.5s
T-2 (2c25489): 5.6s
T-1 (51f5e9e): 5.6s
T (current commit): 5.5s

largeDepsZisi: 10.3s

⬇️ 4.70% decrease vs. 51f5e9e

^                                          10.9s                                   10.7s   10.7s          
│  10.5s   10.3s   10.4s   10.6s   10.4s    ┌──┐   10.2s   10.6s   10.3s   10.5s    ┌──┐    ┌──┐   10.3s  
│ ──┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┼──┼────┌──┐────┌──┐────┌──┐────┌──┐────┼──┼────┼──┼────┌──┐──
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (f146798): 10.4s
T-29 (c7901aa): 10.5s
T-28 (bc7b0b8): 10.5s
T-27 (81e451b): 9.9s
T-26 (daa74ff): 10.3s
T-25 (128b059): 10.7s
T-24 (f01af04): 10.4s
T-23 (44f2871): 10.1s
T-22 (a176e52): 10.4s
T-21 (897284e): 10s
T-20 (30703f8): 10.2s
T-19 (ec7bde9): 10.4s
T-18 (05b3c1a): 10.5s
T-17 (393b490): 10.6s
T-16 (abcba24): 10.1s
T-15 (1b10dd1): 10.7s
T-14 (46377da): 10.6s
T-13 (1a06dac): 10.5s
T-12 (8a3845d): 10.5s
T-11 (8ebae9d): 10.3s
T-10 (655f1a8): 10.4s
T-9 (64ee032): 10.6s
T-8 (f129ca1): 10.4s
T-7 (bd3bd46): 10.9s
T-6 (136119a): 10.2s
T-5 (9e82c5a): 10.6s
T-4 (db2f959): 10.3s
T-3 (ee501c7): 10.5s
T-2 (2c25489): 10.7s
T-1 (51f5e9e): 10.7s
T (current commit): 10.3s

tests/fixtures/ratelimit/netlify/functions/rewrite.ts

src/manifest.ts

src/runtimes/node/in_source_config/index.ts

eduardoboucas

🚀

* feat: extra ratelimit config from source * feat: refactor to a more general config structure * chore: address PR comments * chore: ratelimit -> rate_limit

feat: extra ratelimit config from source

1b27a5c

paulo added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Mar 1, 2024

paulo requested review from rybit and aarthykc March 1, 2024 11:46

paulo self-assigned this Mar 1, 2024

paulo requested a review from a team as a code owner March 1, 2024 11:46

paulo changed the title ~~feat: extra ratelimit config from source~~ feat: ratelimit config from source Mar 7, 2024

paulo marked this pull request as draft March 7, 2024 14:30

feat: refactor to a more general config structure

22fafe8

paulo requested a review from eduardoboucas March 11, 2024 09:38

paulo marked this pull request as ready for review March 11, 2024 09:38

eduardoboucas reviewed Mar 11, 2024

View reviewed changes

tests/fixtures/ratelimit/netlify/functions/rewrite.ts Outdated Show resolved Hide resolved

src/manifest.ts Outdated Show resolved Hide resolved

src/runtimes/node/in_source_config/index.ts Outdated Show resolved Hide resolved

src/runtimes/node/in_source_config/index.ts Show resolved Hide resolved

chore: address PR comments

37b1697

eduardoboucas previously approved these changes Mar 11, 2024

View reviewed changes

chore: ratelimit -> rate_limit

b991f6f

paulo dismissed eduardoboucas’s stale review via b991f6f March 11, 2024 20:21

eduardoboucas approved these changes Mar 12, 2024

View reviewed changes

paulo merged commit f947eb3 into main Mar 12, 2024
10 checks passed

paulo deleted the pa/parse-ratelimit-config branch March 12, 2024 09:01

token-generator-app bot mentioned this pull request Mar 12, 2024

chore(main): release 9.31.0 #1715

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ratelimit config from source #1714

feat: ratelimit config from source #1714

paulo commented Mar 1, 2024

github-actions bot commented Mar 1, 2024 •

edited

Loading

eduardoboucas left a comment

feat: ratelimit config from source #1714

feat: ratelimit config from source #1714

Conversation

paulo commented Mar 1, 2024

Summary

github-actions bot commented Mar 1, 2024 • edited Loading

⏱ Benchmark results

largeDepsEsbuild: 1.3s

largeDepsNft: 5.5s

largeDepsZisi: 10.3s

eduardoboucas left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 1, 2024 •

edited

Loading