fix: remove zisi_go_drop_runtime_override flag #1685

Skn0tt · 2023-12-05T12:07:42Z

Flag is fully rolled out, so it's time to remove it!

Skn0tt · 2023-12-05T12:08:10Z

part of https://github.com/netlify/pod-dev-foundations/issues/581

github-actions · 2023-12-05T12:09:10Z

⏱ Benchmark results

Comparing with 66b668b

largeDepsEsbuild: 1.3s

⬇️ 1.98% decrease vs. 66b668b

^   1.4s                                                                                                  
│   ┌──┐    1.3s                    1.3s                                                    1.3s          
│ ──┼──┼────┌──┐────1.3s────1.2s────┌──┐────1.3s────1.3s────1.3s────1.3s────1.3s────1.3s────┌──┐────1.3s──
│   |  |    |  |    ┌──┐    ┌──┐    |  |    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (05b3c1a): 1.4s
T-29 (393b490): 1.5s
T-28 (abcba24): 1.4s
T-27 (1b10dd1): 1.5s
T-26 (46377da): 1.5s
T-25 (1a06dac): 1.4s
T-24 (8a3845d): 1.5s
T-23 (8ebae9d): 1.4s
T-22 (655f1a8): 1.5s
T-21 (64ee032): 1.4s
T-20 (f129ca1): 1.4s
T-19 (bd3bd46): 1.5s
T-18 (136119a): 1.4s
T-17 (9e82c5a): 1.5s
T-16 (db2f959): 1.5s
T-15 (ee501c7): 1.4s
T-14 (2c25489): 1.3s
T-13 (51f5e9e): 1.3s
T-12 (f947eb3): 1.4s
T-11 (b06d5a2): 1.3s
T-10 (06f408e): 1.3s
T-9 (8591222): 1.2s
T-8 (95285a7): 1.3s
T-7 (1aefa6e): 1.3s
T-6 (7c7ce09): 1.3s
T-5 (9e71c5b): 1.3s
T-4 (5b4140b): 1.3s
T-3 (becb2ac): 1.3s
T-2 (a2071a6): 1.3s
T-1 (66b668b): 1.3s
T (current commit): 1.3s

largeDepsNft: 5.3s

⬆️ 0.44% increase vs. 66b668b

^   5.8s                                    5.7s                                                          
│   ┌──┐    5.5s            5.5s    5.5s    ┌──┐                            5.5s    5.6s                  
│ ──┼──┼────┌──┐────5.3s────┌──┐────┌──┐────┼──┼────5.2s────5.3s────5.3s────┌──┐────┌──┐────5.3s────5.3s──
│   |  |    |  |    ┌──┐    |  |    |  |    |  |    ┌──┐    ┌──┐    ┌──┐    |  |    |  |    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (05b3c1a): 5.5s
T-29 (393b490): 5.6s
T-28 (abcba24): 5.5s
T-27 (1b10dd1): 5.8s
T-26 (46377da): 5.8s
T-25 (1a06dac): 5.6s
T-24 (8a3845d): 5.3s
T-23 (8ebae9d): 5.6s
T-22 (655f1a8): 5.5s
T-21 (64ee032): 5.7s
T-20 (f129ca1): 5.5s
T-19 (bd3bd46): 5.7s
T-18 (136119a): 5.4s
T-17 (9e82c5a): 5.6s
T-16 (db2f959): 5.5s
T-15 (ee501c7): 5.5s
T-14 (2c25489): 5.6s
T-13 (51f5e9e): 5.6s
T-12 (f947eb3): 5.8s
T-11 (b06d5a2): 5.5s
T-10 (06f408e): 5.3s
T-9 (8591222): 5.5s
T-8 (95285a7): 5.5s
T-7 (1aefa6e): 5.7s
T-6 (7c7ce09): 5.2s
T-5 (9e71c5b): 5.3s
T-4 (5b4140b): 5.3s
T-3 (becb2ac): 5.5s
T-2 (a2071a6): 5.6s
T-1 (66b668b): 5.3s
T (current commit): 5.3s

largeDepsZisi: 10.2s

⬆️ 0.01% increase vs. 66b668b

^  10.8s                                                                                                  
│   ┌──┐   10.4s    10s    10.3s   10.4s   10.5s   10.2s    10s     10s    10.3s   10.4s   10.2s   10.2s  
│ ──┼──┼────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐──
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (05b3c1a): 10.5s
T-29 (393b490): 10.6s
T-28 (abcba24): 10.1s
T-27 (1b10dd1): 10.7s
T-26 (46377da): 10.6s
T-25 (1a06dac): 10.5s
T-24 (8a3845d): 10.5s
T-23 (8ebae9d): 10.3s
T-22 (655f1a8): 10.4s
T-21 (64ee032): 10.6s
T-20 (f129ca1): 10.4s
T-19 (bd3bd46): 10.9s
T-18 (136119a): 10.2s
T-17 (9e82c5a): 10.6s
T-16 (db2f959): 10.3s
T-15 (ee501c7): 10.5s
T-14 (2c25489): 10.7s
T-13 (51f5e9e): 10.7s
T-12 (f947eb3): 10.8s
T-11 (b06d5a2): 10.4s
T-10 (06f408e): 10s
T-9 (8591222): 10.3s
T-8 (95285a7): 10.4s
T-7 (1aefa6e): 10.5s
T-6 (7c7ce09): 10.2s
T-5 (9e71c5b): 10s
T-4 (5b4140b): 10s
T-3 (becb2ac): 10.3s
T-2 (a2071a6): 10.4s
T-1 (66b668b): 10.2s
T (current commit): 10.2s

…ip-it#1685)

fix: remove zisi_go_drop_runtime_override flag

ebf07b0

Skn0tt requested a review from a team as a code owner December 5, 2023 12:07

Skn0tt self-assigned this Dec 5, 2023

Skn0tt requested a review from lukasholzer December 5, 2023 12:07

Skn0tt added 2 commits April 11, 2024 15:17

Merge branch 'main' into remove-zisi_go_drop_runtime_override

216b502

Merge branch 'main' into remove-zisi_go_drop_runtime_override

ae95375

eduardoboucas approved these changes Apr 19, 2024

View reviewed changes

Skn0tt merged commit a789be6 into main Apr 19, 2024
10 checks passed

Skn0tt deleted the remove-zisi_go_drop_runtime_override branch April 19, 2024 09:05

token-generator-app bot mentioned this pull request Apr 19, 2024

chore(main): release 9.31.4 #1725

Merged

Skn0tt added a commit to netlify/build that referenced this pull request May 21, 2024

fix: remove zisi_go_drop_runtime_override flag (netlify/zip-it-and-sh…

4b8e53d

…ip-it#1685)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: remove zisi_go_drop_runtime_override flag #1685

fix: remove zisi_go_drop_runtime_override flag #1685

Skn0tt commented Dec 5, 2023

Skn0tt commented Dec 5, 2023

github-actions bot commented Dec 5, 2023 •

edited

Loading

fix: remove zisi_go_drop_runtime_override flag #1685

fix: remove zisi_go_drop_runtime_override flag #1685

Conversation

Skn0tt commented Dec 5, 2023

Skn0tt commented Dec 5, 2023

github-actions bot commented Dec 5, 2023 • edited Loading

⏱ Benchmark results

largeDepsEsbuild: 1.3s

largeDepsNft: 5.3s

largeDepsZisi: 10.2s

github-actions bot commented Dec 5, 2023 •

edited

Loading