Support extensions with multiple parts for gitlab (i.e. en.md) #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for netlify-cms-www ready! Built with commit c90b647 |
|
Deploy preview for netlify-cms-www ready! Built with commit bba97b2 |
tech4him1
suggested changes
Jun 30, 2018
| this.fetchFiles(files.filter(file => fileExtension(file.name) === extension)) | ||
| this.fetchFiles(files.filter(files => | ||
| files.filter(file => file.name.endsWith('.' + extension)) | ||
| ) |
There was a problem hiding this comment.
This whole block should be changed to:
this.fetchFiles(
files.filter(file => file.name.endsWith('.' + extension))
)(there was a duplicate files.filter(files => on the first line of the new code)
|
Deploy preview for cms-demo ready! Built with commit bba97b2 |
|
Changes done. |
|
@Nic128 I'll try to get this merged later today or tomorrow |
erquhart
approved these changes
Jul 2, 2018
|
There are more places that use the |
tech4him1
suggested changes
Jul 7, 2018
|
Done. |
|
Is there more to do for this PR? |
|
So sorry, I've been pretty much offline for the last 2 weeks. I'll try to review ASAP. @erquhart Maybe we can get this in the next patch release if possible? |
tech4him1
approved these changes
Jul 21, 2018
|
@Nic128 Released in v1.9.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Fixes #1462. See discussion there for context.
- Test plan
I ported the exact fix from #1123 to gitlab.
- Description for the changelog
Support extensions with multiple parts for gitlab (i.e. en.md)
- A picture of a cute animal (not mandatory but encouraged)