Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reading data from spawned process #5877

Merged
merged 2 commits into from
Oct 9, 2024
Merged

fix: reading data from spawned process #5877

merged 2 commits into from
Oct 9, 2024

Conversation

VitaliyR
Copy link
Contributor

@VitaliyR VitaliyR commented Oct 9, 2024

🎉 Thanks for submitting a pull request! 🎉

Summary

Spawned processes might return a random data, while ipc.js, when filters messages, expects it to be in array format.

When process sends non-array object, it produces the uncaught error and stops the build.

I've discovered this when started netlify dev with plugin-visual-editor on the site with astro and sanity. Plugin-visual-editor launches stackbit dev, which imports a content-engine, which calls process.send(/* OBJECT */) and crashes the build.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Copy link
Contributor

github-actions bot commented Oct 9, 2024

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

Copy link
Contributor

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding a fixture!

Copy link

sonarcloud bot commented Oct 9, 2024

@VitaliyR VitaliyR merged commit 5860e72 into main Oct 9, 2024
39 checks passed
@VitaliyR VitaliyR deleted the fix/process-response branch October 9, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants