Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provide failBuild to getProject calls #247

Merged

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Feb 6, 2025

We've not been passing all the arguments to getProject (

const getProject = (angularJson, failBuild) => {
) resulting in

 TypeError: failBuild is not a function
     at getProject (/opt/build/repo/node_modules/@netlify/angular-runtime/src/helpers/setUpEdgeFunction.js:30:14)

kind of errors that hide actual error from the user and making it unnecessarily difficult to see underlying problem

Ideally we also introduce some typechecking to prevent this kind of problems, but this is just quick fix to solve concretely known issue

fixes #246
fixes https://linear.app/netlify/issue/FRB-1619/angular-19-ssr-and-the-angular-runtime

@pieh pieh requested a review from a team as a code owner February 6, 2025 07:42
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Feb 6, 2025
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for plugin-angular-universal-demo ready!

Name Link
🔨 Latest commit e5ab050
🔍 Latest deploy log https://app.netlify.com/sites/plugin-angular-universal-demo/deploys/67a467e7b47d64000844ef1c
😎 Deploy Preview https://deploy-preview-247--plugin-angular-universal-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@orinokai orinokai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward to me ✅

@pieh pieh merged commit 9a3b1bd into main Feb 6, 2025
29 checks passed
@pieh pieh deleted the michalpiechowiak/frb-1619-angular-19-ssr-and-the-angular-runtime branch February 6, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 19, SSR, and the Angular Runtime
2 participants