feat: Puppeteer Adapter #64

offirgolan · 2018-07-15T06:04:50Z

Puppeteer Adapter
Refactor tests so they are re-usable by all adapters/persisters

import { Polly } from '@pollyjs/core';
import PuppeteerAdapter from '@pollyjs/adapter-puppeteer';

Polly.register(PuppeteerAdapter);

const browser = await puppeteer.launch();
const page = await this.browser.newPage();

await page.setRequestInterception(true);

new Polly('<Recording Name>', {
  adapters: ['puppeteer'],
  adapterOptions: {
    puppeteer: { page }
  }
});

await page.goto('https://netflix.com');

offirgolan · 2018-07-15T06:08:27Z

packages/@pollyjs/core/src/utils/normalize-request.js

-
-    parsedUrl.set('query', sortedQuery);
+  if (isObjectLike(parsedUrl.query)) {
+    parsedUrl.set('query', parse(stringify(parsedUrl.query)));


Realized the stable stringify will do all the hard work for us 😄

offirgolan · 2018-07-15T06:09:01Z

packages/@pollyjs/adapter/src/index.js

        statusText,
+        statusCode: status,


Have a similar api to our Response class.

offirgolan · 2018-07-15T06:11:21Z

packages/@pollyjs/persister-fs/tests/integration/persister-test.js

+// import persisterTests from '@pollyjs-tests/integration/persister-tests';
+// import { setupMocha as setupPolly, FetchAdapter } from '@pollyjs/core';
+
+// // TODO: re-enable once the fetch adapter can accept a context


TODO: re-enable once the fetch adapter can accept a context

offirgolan · 2018-07-15T06:16:19Z

build-scripts/rollup.browser.test.config.js

@@ -18,7 +19,7 @@ export default function createBrowserTestConfig(options = {}) {
          `,
          outro: '});'
        },
-        plugins: [multiEntry()]
+        plugins: [alias({ '@pollyjs-tests': testsPath }), multiEntry()]


Add an alias to our common tests directory so we dont have to use relative paths everywhere.

jasonmit · 2018-07-15T09:02:16Z

packages/@pollyjs/adapter-puppeteer/src/index.js

+        if (requestResourceTypes.includes(request.resourceType())) {
+          this.handleRequest({
+            url: request.url(),
+            method: request.method() || 'GET',


fallback required?

jasonmit · 2018-07-15T09:12:07Z

packages/@pollyjs/adapter-puppeteer/src/index.js

+  }
+
+  async _passthroughRequest(pollyRequest) {
+    const response = await fetch(pollyRequest.url, {


This will lead to unexpected behavior given the different nature of node-fetch vs browser fetch. I.e., credentials

jasonmit · 2018-07-15T09:20:48Z

packages/@pollyjs/adapter-puppeteer/tests/integration/adapter-test.js

+      headers: {
+        exclude: [
+          // We don't want new recordings when we update chrome
+          'user-agent',


Should we default?

shanemcgraw · 2018-07-16T20:35:21Z

Hey there @offirgolan - this looks amazing! Wondering if this will close #19?

offirgolan · 2018-07-16T20:41:33Z

@shanemcgraw thanks! Im not entirely sure if that will fully resolve #19. I'll leave it open in the mean time until I'm more certain.

jasonmit · 2018-07-16T20:58:09Z

I landed the parts that enable Jest to work.

I kept the issue open until we document the jest setup process and add test coverage before we officially advertise it's supported.

Some of that context is in the issue regarding setting up. PRs welcome if anyone wants to sheppard these changes. Otherwise, likely next on my list.

offirgolan added 3 commits July 12, 2018 15:37

feat: Puppeteer adapter

1ddcdca

test: Initial puppeteer tests

bdae7c1

refactor: Move common tests out to tests/ + add tests

19e9ae0

offirgolan requested a review from jasonmit July 15, 2018 06:04

offirgolan commented Jul 15, 2018

View reviewed changes

fix: Add node-fetch to external

f32659f

offirgolan commented Jul 15, 2018

View reviewed changes

jasonmit reviewed Jul 15, 2018

View reviewed changes

offirgolan added 2 commits July 15, 2018 12:19

fix: Remove node-fetch dependency

9ecd141

test: Add unit tests

3d625b8

offirgolan requested a review from jasonmit July 15, 2018 19:40

offirgolan merged commit f902c6d into master Jul 15, 2018

offirgolan deleted the adapter-puppeteer branch July 15, 2018 19:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Puppeteer Adapter #64

feat: Puppeteer Adapter #64

offirgolan commented Jul 15, 2018 •

edited

Loading

offirgolan Jul 15, 2018

offirgolan Jul 15, 2018

offirgolan Jul 15, 2018

offirgolan Jul 15, 2018

jasonmit Jul 15, 2018

jasonmit Jul 15, 2018 •

edited

Loading

jasonmit Jul 15, 2018 •

edited

Loading

shanemcgraw commented Jul 16, 2018

offirgolan commented Jul 16, 2018

jasonmit commented Jul 16, 2018 •

edited

Loading

feat: Puppeteer Adapter #64

feat: Puppeteer Adapter #64

Conversation

offirgolan commented Jul 15, 2018 • edited Loading

offirgolan Jul 15, 2018

Choose a reason for hiding this comment

offirgolan Jul 15, 2018

Choose a reason for hiding this comment

offirgolan Jul 15, 2018

Choose a reason for hiding this comment

offirgolan Jul 15, 2018

Choose a reason for hiding this comment

jasonmit Jul 15, 2018

Choose a reason for hiding this comment

jasonmit Jul 15, 2018 • edited Loading

Choose a reason for hiding this comment

jasonmit Jul 15, 2018 • edited Loading

Choose a reason for hiding this comment

shanemcgraw commented Jul 16, 2018

offirgolan commented Jul 16, 2018

jasonmit commented Jul 16, 2018 • edited Loading

offirgolan commented Jul 15, 2018 •

edited

Loading

jasonmit Jul 15, 2018 •

edited

Loading

jasonmit Jul 15, 2018 •

edited

Loading

jasonmit commented Jul 16, 2018 •

edited

Loading