Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ember): Upgrade ember-cli-babel to ^7.26.6 #411

Merged
merged 2 commits into from
Nov 24, 2021

Conversation

rmachielse
Copy link
Contributor

Resolves this deprecation with ember 3.27+:

DEPRECATION: Usage of the Ember Global is deprecated. You should import the Ember module or the specific API instead.

See https://deprecations.emberjs.com/v3.x/#toc_ember-global for details.

Usages of the Ember Global may be caused by an outdated ember-cli-babel dependency. The following steps may help:

  • Upgrade the following addons to the latest version:
    • @pollyjs/ember

@rmachielse
Copy link
Contributor Author

@jasonmit @cibernox @offirgolan who can have a look at this? This should be a simple change but gets us unstuck.

@offirgolan
Copy link
Collaborator

@rmachielse the yarn.lock has not been updated with this version bump. Are there any other changes that need to be done to upgrade to [email protected]?

@rmachielse
Copy link
Contributor Author

rmachielse commented Nov 23, 2021

@offirgolan true, but I didn't see one in the package folder, should I update from the root folder? As far as I'm aware no other changes are needed.

@offirgolan
Copy link
Collaborator

Yeah, you'll need to run yarn install at the root

@rmachielse rmachielse changed the title Upgrade ember-cli-babel to ^7.26.6 feat(ember): Upgrade ember-cli-babel to ^7.26.6 Nov 24, 2021
@rmachielse
Copy link
Contributor Author

@offirgolan okay, I updated the yarn.lock file. I also updated the commit message to comply with the desired format.

@offirgolan offirgolan merged commit 4352881 into Netflix:master Nov 24, 2021
@rmachielse rmachielse deleted the patch-1 branch November 24, 2021 18:47
@offirgolan
Copy link
Collaborator

Released @pollyjs/[email protected]. Thanks for the PR!

@rmachielse
Copy link
Contributor Author

@offirgolan thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants